Re: How to stop building when sub-make returns error

[elight]

I found the reason.

If running following makefile, it proceeds to the 'three' target.

all : one two three 

one : 
        @echo $@ 

two : 
        $(MAKE) error 2>&1 | grep error
        @echo $@ 

three : 
        @echo $@ 

error : 
        grep whatever idontexist 

Will return:

one
make error 2>&1 | grep error
make[1]: *** [error] Error 2
two
three

Redirection and piping make different result.
Hmm. It's a bug or not?



Paljas wrote:
> 
> 
> elight wrote:
>> 
>> I have GNU make V3.81.
>> 
>> The rules for building system is like this:
>> 
>> all: pre_build main_build post_build
>> 
>> pre_build:
>>     ...
>> 
>> main_build:
>>     make -C $(BUILD_DIR) -r -f $(MAKEFILE)
>> 
>> post_build
>>     ...
>> 
>> Althouth the sub-make for the target 'main_build' makes an error, build
>> process proceeds to post_build.
>> I wish the build process would be stop when the sub-make has an error.
>> 
>> 
> The default behavior for make is to exit once a command returns an error,
> so I'm surprised that it goes wrong at your side. The following makefile:
> 
> all : one two three
> 
> one :
>       @echo $@
> 
> two :
>       $(MAKE) error
>       @echo $@
> 
> three :
>       @echo $@
> 
> error :
>       grep whatever idontexist
> 
> Will return:
> 
> one
> make error
> make[1]: Entering directory `/tmp'
> grep whatever idontexist
> grep: idontexist: No such file or directory
> make[1]: *** [error] Error 2
> make[1]: Leaving directory `/tmp'
> make: *** [two] Error 2
> 
> You'll notice that three is never built. That's because grep returns an
> error.
> 
> PS: Beware! GNU make does NOT guarantee that prerequisites are built in
> the order you specify them! The order depends on the depth of the
> dependency tree for each prerequisite. If you want to guarantee proper
> order, you should force it by dependency hierarchy, e.g.:
> 
> post_build : main_build ;
> main_build : pre_build ;
> pre_build :
> 
> Regards,
> Paljas.
> 

-- 
View this message in context: 
http://old.nabble.com/How-to-stop-building-when-sub-make-returns-error-tp27122668p27126207.html
Sent from the Gnu - Make - Help mailing list archive at Nabble.com.