Re: package database-2.4.0 released

[Montgomery-Smith, Stephen]

On 03/18/2016 11:02 AM, Olaf Till wrote:
> On Fri, Mar 18, 2016 at 02:54:12PM +0000, Montgomery-Smith, Stephen wrote:
>> I acquired the package from sourceforge.
> 
> Where exactly from sourceforge? The official package at
> 
> https://sourceforge.net/projects/octave/files/Octave%20Forge%20Packages/Individual%20Package%20Releases/database-2.4.0.tar.gz/download?use_mirror=netix&download=
> 
> , or
> 
> from the Mercurial repository?

From the former.

> 
>> I was building via an update
>> of the FreeBSD port https://www.freshports.org/math/octave-forge-database/
> 
> I don't understand this.

It basically goes into the directory src, and then does ./configure
followed by make install.  However it has a bunch of FreeBSD specific
variables set, so who know what effect that would have.


> 
>> Based upon your reply, I edited Makefile.in as follows, which fixed the
>> problem.  Is this legitimate?
>>
>> --- Makefile.in.orig    2016-03-18 14:46:25 UTC
>> +++ Makefile.in
>> @@ -45,7 +45,7 @@ MFILES := $(wildcard *.m) $(wildcard ../
>>
>>  .INTERMEDIATE: MFDOCSTRINGS $(DSFILES)
>>
>> -all: doc $(octs)
>> +all: $(octs)
>>
>>  release: doc html
> 
> I don't know yet. If you used the official package, has it been
> somehow changed? Is doc/database.info still in it?

Yes, that's still there.

> Maybe the
> timestamps are wrong so that it is rebuilt? Could you paste the output
> of 'ls -l doc/ inst/ src/' (before building)?

doc/:
total 110
-rw-r--r--  1 stephen  staff    320 Mar 16 16:57 README
-rw-r--r--  1 stephen  staff   1493 Mar 16 16:57 README-postgresql
-rw-r--r--  1 stephen  staff  38765 Mar 16 16:58 database.info
-rw-r--r--  1 stephen  staff  36063 Mar 16 16:58 database.texi
-rw-r--r--  1 stephen  staff  24048 Mar 16 16:57 database.txi
drwxr-xr-x  2 stephen  staff    512 Mar 16 16:57 dev-postgresql
drwxr-xr-x  2 stephen  staff   1536 Mar 16 16:58 html
-rw-r--r--  1 stephen  staff   2513 Mar 16 16:57 macros.texi

inst/:
total 34
-rw-r--r--  1 stephen  staff  2043 Mar 16 16:57 __all_db_opts__.m
-rw-r--r--  1 stephen  staff  2641 Mar 16 16:57 database_doc.m
-rw-r--r--  1 stephen  staff  1776 Mar 16 16:57 getdbopts.m
-rw-r--r--  1 stephen  staff  8471 Mar 16 16:57 pq_connect.m
-rw-r--r--  1 stephen  staff  6255 Mar 16 16:57 pq_exec_params.m
-rw-r--r--  1 stephen  staff  3154 Mar 16 16:57 pq_lo_view.m
-rw-r--r--  1 stephen  staff  3913 Mar 16 16:57 setdbopts.m

src:
total 348
-rw-r--r--  1 stephen  staff    4771 Mar 16 16:57 Makefile.in
-rw-r--r--  1 stephen  staff    1604 Mar 16 16:57 __pq_connect__.cc
-rw-r--r--  1 stephen  staff    1592 Mar 16 16:57 __pq_internal_exit__.cc
-rwxr-xr-x  1 stephen  staff      21 Mar 16 16:57 bootstrap
-rw-r--r--  1 stephen  staff    3363 Mar 16 16:57 bytea2var.cc
-rw-r--r--  1 stephen  staff   25803 Mar 16 16:57 command.cc
-rw-r--r--  1 stephen  staff    3251 Mar 16 16:57 command.h
-rw-r--r--  1 stephen  staff     239 Mar 16 16:57 config.h.in
-rwxr-xr-x  1 stephen  staff  131490 Mar 16 16:58 configure
-rw-r--r--  1 stephen  staff    3322 Mar 16 16:57 configure.ac
-rw-r--r--  1 stephen  staff   58807 Mar 16 16:57 converters.cc
-rw-r--r--  1 stephen  staff    9668 Mar 16 16:57 converters.h
-rw-r--r--  1 stephen  staff   17596 Mar 16 16:57 converters_arr_comp.cc
-rw-r--r--  1 stephen  staff    1231 Mar 16 16:57 error-helpers.cc
-rw-r--r--  1 stephen  staff    3320 Mar 16 16:57 error-helpers.h
-rwxr-xr-x  1 stephen  staff    2263 Mar 16 16:57 mkdoc.pl
-rwxr-xr-x  1 stephen  staff    4691 Mar 16 16:57 munge-texi.pl
-rw-r--r--  1 stephen  staff    1515 Mar 16 16:57 pq_close.cc
-rw-r--r--  1 stephen  staff   17783 Mar 16 16:57 pq_connection.cc
-rw-r--r--  1 stephen  staff    3323 Mar 16 16:57 pq_connection.h
-rw-r--r--  1 stephen  staff    2485 Mar 16 16:57 pq_conninfo.cc
-rw-r--r--  1 stephen  staff    9936 Mar 16 16:57 pq_exec.cc
-rw-r--r--  1 stephen  staff   17330 Mar 16 16:57 pq_lo.cc
-rw-r--r--  1 stephen  staff    1836 Mar 16 16:57 pq_update_types.cc
-rw-r--r--  1 stephen  staff    3397 Mar 16 16:57 var2bytea.cc
-rw-r--r--  1 stephen  staff    1407 Mar 16 16:57 wrap_endian.h


> 
> Apart from the question why it is rebuild, I'd also like to know why
> rebuilding goes wrong. Can you insert this in 'munge-texi.pl':
> 
> --- database/src/munge-texi.pl  2016-03-09 07:14:16.461738357 +0100
> +++ tp/database-2.4.0/src/munge-texi.pl 2016-03-18 10:13:13.450932703 +0100
> @@ -36,6 +36,8 @@
>  {
>    open (DOCFH, $DOCSTRING_file) or die "Unable to open $DOCSTRING_file\n";
>  
> +  warn "$DOCSTRING_file\n";
> +
>    # Skip comments
>    while (defined ($_ = <DOCFH>) and /$comment_line/o) {;}
> 
> and build, and paste the output, so that I see in which file it fails?
> If it is 'MFDOCSTRINGS', you can send me this also (better
> off-list). If it's another one, I'll have further questions ...
> 
> Olaf
> 

It is MFDOCSTRINGS.  But I cannot find any file by that name.

signature.asc
Description: OpenPGP digital signature