help-shishi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Segfaults in authorization type setting.


From: Simon Josefsson
Subject: Re: Segfaults in authorization type setting.
Date: Wed, 08 Aug 2012 12:41:19 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/23.3 (gnu/linux)

Mats Erik Andersson <address@hidden> writes:

> The functions
>
>   shishi_cfg_clientkdcetype_set()
>
> and
>
>   shishi_cfg_authorizationtype_set()
>
> are both throwing segmentation faults every time
> they are fed with constant value strings. The reason
> is that they both depend on strtok_r() which must
> be given writeable strings. Simple calls to xstrdup()
> resolve this issue.
>
> As a second matter, both functions always return SHISHI_OK.
> This is not reasonable, so a change is implemented that returns
> SHISHI_OK whenever at least one valid value was found and set
> for the intended configuration entity.

Thank you, applied.

/Simon



reply via email to

[Prev in Thread] Current Thread [Next in Thread]