Re: cvs-1.11.10 win32 VC98 cannot find "assert" during build

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi David,

You need to comment out this line: 

>     assert ( isdir ( path ) );

the change has already already been committed to the cvs1-11-x-branch
of the repository.

        Thanks,
        -- Mark

David Everly <address@hidden> writes:

> The following command builds cvs-1.11.9, but not cvs-1.11.10 under
> windows:
> 
>    nmake /f cvsnt.mak CFG="cvsnt - Win32 Debug"
> 
> The failure appears to be:
> 
>       link.exe @c:\temp\nma01012.
> filesubr.obj : error LNK2001: unresolved external symbol _assert
> .\WinDebug/cvs.exe : fatal error LNK1120: 1 unresolved externals
> NMAKE : fatal error U1077: 'link.exe' : return code '0x460'
> Stop.
> 
> There is related information about "assert" earlier in the build
> log:
> 
>         cl.exe /nologo /MLd /W3 /Gm /GX /Zi /Ob1 /I "windows-NT" /I
> "lib" /I "src" /I "zlib" /D "_DEBUG" /D "WIN32" /D "_CONSOLE" /D
> "HAVE_CONFIG_H" /Fp".\WinDebug/cvsnt.pch" /YX /Fo".\WinDebug/"
> /Fd".\WinDebug/" /c ".\windows-NT\filesubr.c"
> filesubr.c
> .\windows-NT\filesubr.c(766) : warning C4013: 'assert' undefined;
> assuming extern returning int
> 
> My compiler is Microsoft Visual Studio / VC98.
> 
> I don't know much about building on windows, not sure what else
> to provide, so here is the seemingly related source code change:
> 
> windows-NT$ cvs diff -rcvs_1_11_9 -rcvs_1_11_10 filesubr.c 
> Index: filesubr.c
> ===================================================================
> RCS file: /users/home/tibco/tibadmin/cvs/cvs/windows-NT/filesubr.c,v
> retrieving revision 1.1.1.1
> retrieving revision 1.1.1.2
> diff -r1.1.1.1 -r1.1.1.2
> 743a744,782
> > /* char *
> >  * xresolvepath ( const char *path )
> >  *
> >  * Like xreadlink(), but resolve all links in a path.
> >  *
> >  * INPUTS
> >  *  path    The original path.
> >  *
> >  * RETURNS
> >  *  The path with any symbolic links expanded.
> >  *
> >  * ERRORS
> >  *  This function exits with a fatal error if it fails to read the link for
> >  *  any reason.
> >  */
> > char *
> > xresolvepath ( path )
> >     const char *path;
> > {
> >     char *hardpath;
> >     char *owd;
> > 
> >     assert ( isdir ( path ) );
> > 
> >     /* FIXME - If HAVE_READLINK is defined, we should probably walk the path
> >      * bit by bit calling xreadlink().
> >      */
> > 
> >     owd = xgetwd();
> >     if ( CVS_CHDIR ( path ) < 0)
> >     error ( 1, errno, "cannot chdir to %s", path );
> >     if ( ( hardpath = xgetwd() ) == NULL )
> >     error (1, errno, "cannot readlink %s", hardpath);
> >     if ( CVS_CHDIR ( owd ) < 0)
> >     error ( 1, errno, "cannot chdir to %s", owd );
> >     free (owd);
> >     return hardpath;
> > }
> > 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQE/39dz3x41pRYZE/gRAhGxAKCYR6Dml5+ucaa8WjVZybLOtQkcsACgxAPR
UIaX9xHD9X4g/QkiHkNI3FY=
=elDI
-----END PGP SIGNATURE-----