info-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FW: Possible bug in socket-client.c


From: Mark D. Baushke
Subject: Re: FW: Possible bug in socket-client.c
Date: Tue, 06 Jan 2004 15:36:45 -0800

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

"Michael Lemke, Sternwarte Bamberg, Phone: +49-951-9522216" writes:

> I haven't seen this is on the list yet so I try again:
> 
> 
> While making cvs 1.12.5 compile on VMS again I came across a problem in
> src/socket-client.c.  Proposed patch against 1.12.5:
> 
> A400> cvs -z3 diff -ur "HEAD" socket-client.c
> Index: socket-client.c
> ===================================================================
> RCS file: /cvs/ccvs/src/socket-client.c,v
> retrieving revision 1.11
> diff -u -r1.11 socket-client.c
> --- socket-client.c     18 Nov 2003 20:02:23 -0000      1.11
> +++ socket-client.c     2 Jan 2004 19:24:16 -0000
> @@ -84,7 +84,7 @@
> 
>  struct buffer *
>  socket_buffer_initialize( int socket, int input,
> -                          void *memory( struct buffer * ) )
> +                          void (*memory)( struct buffer * ) )
>  {
>      struct socket_buffer *sbuf = xmalloc (sizeof *sbuf);
>      sbuf->socket = socket;

Committed to development tree.

> 
> This makes it conform to the declaration in socket-client.h.  Not sure
> if it makes it work as intendend, though...

Yes, it matches the declaration for buf_initialize which is the right
thing.

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQE/+0aN3x41pRYZE/gRAmiAAKCzqGxi6JptpZgli+xooZWh5Xxw2ACeOlIy
xgOXVUMzVCZ7LBdaOtCsFgw=
=rI6q
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]