Re: [mtools] mtools.spec

[Moritz Barsnick]

Hi Peter, hi list,

On Wed, Jun 30, 2004 at 12:52:15 +0200, Peter Fokker wrote:

> Today I created a fresh mtools-RPM using the specfile at
> http://www.tux.org/pub/knaff/mtools/mtools.spec.

Good point!

> -strip %{_bindir}/mtools %{_bindir}/mkmanifest %{_bindir}/floppyd
> +strip %{buildroot}%{_bindir}/mtools %{buildroot}%{_bindir}/mkmanifest 
> %{buildroot}%{_bindir}/floppyd

In "modern distributions" (I know for sure about RedHat/Fedora, I also
think in MandrakeLinux), stripping is done by rpmbuild, and is not
recommended manually. (They now even build -debuginfo packages first,
and then strip all binaries for the standard package. For debugging,
you then install the -debuginfo _additionally_.)

> +%clean
> +rm -r %{_tmppath}/%{name}-%{version}-buildroot

a) "rm -rf" is the more common approach.
b) I think you mean "rm -rf %{buildroot}". (Some packagers also tend to
   check whether %{buildroot} == '/', but you shouldn't be running
   rpmbuild as root anyway. ;->)

Regards,
Moritz   :)
_______________________________________________
mtools mailing list
address@hidden
http://www.tux.org/mailman/listinfo/mtools