[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Info-mtools] [PATCH] misc.c: Make the output reproducible
From: |
Chris Lamb |
Subject: |
Re: [Info-mtools] [PATCH] misc.c: Make the output reproducible |
Date: |
Tue, 30 Oct 2018 00:34:59 -0400 |
Dear Pali,
> > Can't quite parse this; so simply strtoll → strtoull will "just work" in
> > that I already check errno for ERANGE?
>
> No. You should avoid usage of strtoull, so change strtoull → strtoll.
Mea culpa, I typo'd here; I meant strtoull → strtoll indeed and ACK
your further comments on errno/ERANGE/underflow, etc.
Updated patch attached that uses strtoll. Thank you again for your
review.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` address@hidden / chris-lamb.co.uk
`-
misc.c-Make-the-output-reproducible.patch
Description: Text Data