[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Some libl4 patches

From: Neal H. Walfield
Subject: Re: Some libl4 patches
Date: Thu, 06 Jan 2005 09:31:31 +0000
User-agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.2 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI)

Hi Matthieu,

I haven't looked at your patch in detail yet but I will.

Just to let you know, right now we do not use string items at all in
the Hurd.  This doesn't mean that we won't nor does it mean that we
don't want libl4, it just means that as you have observed, the code is
not well tested.

Next, please supply a change log entry.  For an example of a change
log entry, look in the ChangeLog files and in the GNU Coding
Standards.  It is important that this is included.

Also, can you please fix your indentation to be consistent with ours.
For instance, in the last hunk of your patch, you have:

        +  if(msg_buffer[1])

This should be:

        +  if (msg_buffer[1])

Note the space.  All of this is covered in the GNU coding standards
(and if you use emacs, tab helps a lot with indentation).

A very minor nit: please use -p when generating diffs.  This makes
them slightly easier to read.

Finally, for something a bit more positive: your explanation of what
is wrong is excellent and a text like this should accompany all

Thanks for you contribution.  I will review the patch in more detail
in the near future.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]