[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wortel.h patch

From: Marcus Brinkmann
Subject: Re: wortel.h patch
Date: Mon, 10 Jan 2005 22:28:39 +0100
User-agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.3 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI)

At Sat, 08 Jan 2005 22:23:41 +0100,
Bas Wijnen <address@hidden> wrote:
> Here's a small patch to change grants to maps in wortel.h.  I guess this 
> was overlooked when wortel.c was changed to do mapping instead of 
> granting.

Yes, good catch.

> I have used this some time ago, and it worked back then.  As 
> these items are only used for receiving memory, I can't imagine it 
> making a difference anyway, as long as there is no type checking for 
> this in L4 (and appearantly there isn't, otherwise it wouldn't have 
> worked without this patch).

Unfortunately, the code even breaks the strict aliasing rules (I use
l4_word_t * a bit like a char * here --- with char * it would work, but
not with l4_wort_t * mpfh).

> As a side note: can hurd-l4 bugs also be reported through savannah, or 
> is that only meant for the mach port?

I could make a category for that, if you think it is useful (ie, if
you want to use it).
> I also noticed that I had some spelling corrections of 
> libhurd-cap-server/README in my tree, I'm attaching a patch with those 
> as well.

Applied as well.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]