[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libhurd-cap-server/class-alloc.c

From: Marcus Brinkmann
Subject: Re: libhurd-cap-server/class-alloc.c
Date: Mon, 17 Jan 2005 06:05:02 +0100
User-agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.3 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI)

At Sun, 16 Jan 2005 12:46:10 -0500,
Neal H. Walfield wrote:
> hurd_cap_class_alloc manipulates the object slab
> (i.e. CAP_CLASS->OBJ_SPACE) but does not lock the class.  Since the
> locking interface is not exported, callers can't be expected to lock
> the class.  Here is a patch to change hurd_cap_class_alloc to lock
> CAP_CLASS.  Okay to check in?

Funny enough, locking is not required, as the slab space already is
protected by its own internal lock.

Unless we want to make guarantees about serialized invocation of the
user's hook functions.  What do you think?

In any case, at least a comment needs to be added, to make it clear.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]