[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libcdio-devel] [PATCH] buffer overflow and fixes from static analys
|
From: |
Rocky Bernstein |
|
Subject: |
Re: [Libcdio-devel] [PATCH] buffer overflow and fixes from static analysis |
|
Date: |
Thu, 2 Jun 2011 17:24:03 -0400 |
On Thu, Jun 2, 2011 at 5:15 PM, Robert William Fuller <
address@hidden> wrote:
> Hi,
>
> Was the sprintf patch applied?
Yes.
> Some of the lines, such as this one:
>
> + snprintf(volpath, 256, "%s/s0", globbuf.gl_pathv[i]);
>
> Should probably be like this instead:
>
> + snprintf(volpath, sizeof(volpath), "%s/s0", globbuf.gl_pathv[i]);
>
Yes, I made changes like this when I applied the patch.
>
> But, that is just my opinion.... I am not a fan of redundancy.
>
Me neither - or is that redundant?
>
> Thoughts? Thank you!
>
> Rob
>
>