Re: [libmicrohttpd] [PATCH] Added support for TCP NODELAY

[silvioprog]

Very nice Evgeny, I'm expecting anxiously this feature! :-D

On Fri, Nov 20, 2015 at 6:30 AM, Evgeny Grin <address@hidden> wrote:

Hi, Silvio

 

You patch will turn on TCP_NODELAY globally upon request, but it should be used at specific moments as Martin Bonner pointed in http://lists.gnu.org/archive/html/libmicrohttpd/2015-11/msg00073.html

You also shift values in emun which will result in breaking ABI compatibility (programs compiled with older version of MHD will not work as expected with newer versions).

TCP_NODELAY is not configuration option, it's system value, so it shouldn't be defined in MHD_config.h (or as -D parameter) as in that case it will conflict with system value and confuse code about really available system options.

I will fix code based on your and Martin Bonner finding.

 

 

-- 

Best Wishes,

Evgeny Grin

--

Silvio Clécio