[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libreboot-dev] MacBook2,1 bug hunt -- patch
From: |
Albin |
Subject: |
Re: [Libreboot-dev] MacBook2,1 bug hunt -- patch |
Date: |
Wed, 3 Feb 2016 13:30:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
Hi,
Here is a patch that fixes the menu entry
"Search for GRUB configuration".
Applied on master following the commit
af1cd6089b1710d07e697bc3a2254c90c36397fe.
Albin
Den 2016-02-01 kl. 15:27, skrev Albin:
> Hi,
>
> I've finally tracked down the outstanding bug d). It wasn't
> as I had thought introduced with the "auto-boot" merge
> in October but already in August. (The "auto-boot" commit
> only refused to show the sub menu that would have contained
> an unloadable .cfg reference.)
>
> Bug d) appeared on August 16 with the commit
> ee9f1bd4dc64786026c34267919441266c49c039,
> "grub.cfg: simplify (remove repetition)".
>
> I successfully removed it from a recent libreboot version
> (2016-01-23:06:37, bcf3ffdfe2ea88e34a915be3a08b04b2d8ec2c8e)
> by replacing the code inside the menu entry with the one from
> 2015-08-16:17:23 (attached) and recompiling. Now I can load
> the GuixSD USB installer and have none of the bugs a–e.
>
> I don't submit a patch this time because I wasn't able to
> build the very latest libreboot version and because I thought
> that you might prefer a different solution than just using the
> code from August. If you choose a rewrite I'm happy to
> test it on my hardware.
>
>
> Bugs present in various revisions
> =================================
>
> I reflashed my MacBook a few more times since and have
> updated the table accordingly. I left out the "R" column
> this time and also didn't check for bug e) since it's
> not present in the most recent version anyway (thus the
> question marks below).
>
> |=======================================|
> | Date and time | a | b | c | d | e |
> |=======================================|
> | 2015-05-18-stable | x | x | | | |
> |---------------------------------------|
> | 2015-06-14:17:02 | | | | | |
> |---------------------------------------|
> | 2015-06-15:20:15 | | | | | |
> |---------------------------------------|
> | 2015-08-04:23:39 | | | | | ? |
> |---------------------------------------|
> | 2015-08-16:17:23 | | | | | ? |
> |---------------------------------------|
> | 2015-08-16:21:29 | | | | x*| ? |
> |---------------------------------------|
> | 2015-09-03:03:09 | | x | | x | ? |
> |---------------------------------------|
> | 2015-09-20:09:27 | | x | | x | ? |
> |---------------------------------------|
> | 2015-09-28:06:23 | | x | | x | ? |
> |---------------------------------------|
> | 2015-10-06:23:25 | | | x | x | ? |
> |---------------------------------------|
> | 2015-10-06:23:40 | | x | | x | x |
> |---------------------------------------|
> | 2015-11-29:22:56 | | | | x | x |
> |---------------------------------------|
> | 2015-12-15:23:15 | | | | x | x |
> |---------------------------------------|
> | 2016-01-23:06:37 | | | | x | |
> |---------------------------------------|
>
> * "Search for GRUB configuration" finds the grub.cfg file
> in the GuixSD USB installer, but when I try to load it
> I get "error: filename expected. Press any key to continue."
>
>
> Happy hacking!
>
> Albin
>
0001-Fix-the-menu-entry-Search-for-GRUB-configuration.patch
Description: Text Data
signature.asc
Description: OpenPGP digital signature