Re: [Librefm-discuss] New member, status check

[Torbjörn Stabo]

Den 2016-07-01 kl. 18:26, skrev Justin W. Flory:
> On 07/01/2016 09:56 AM, Torbjörn Stabo wrote:
> > Hi.
> >   I'd like to say hi to all on this list, if it's ok, and offer to do
> > some work on the project. If the project is still alive? I've cloned the
> > repos mentioned on https://gnu.io/fm/developers/, are they up to date? I
> > get a fair load of PHP messages(strict, undefined index, etc..) using
> > that code on my test server, I make them go away as I find them. I also
> > found a page saying that the database had crashed, though I can't find
> > my way back to it now.
> >
> >   I've been working as a web developer now for 6+ years, doing the
> > pretty much usual things: PHP, SQL, HTML, CSS, Javascript. So I'd like
> > to hope I have the skill set to be here :). If I'm not alone here(?)
> > I'll create a pull request after testing all parts of the system.
> > /Regards, Torbjörn Stabo
>
> Hi Torbjörn,
>
> Firstly, a disclaimer, I am neither a contributor to Libre.fm or even 
> that familiar with the specific development practices of the project. 
> So everything that follows is just my own personal advice / thoughts.
>
> Looking over the project repository, it certainly seems to be 
> maintained, with the last commit from Matt Lee being around 17 days 
> ago. I've seen Matt across Reddit and a handful of other places 
> advocating the project, so I'm inclined to say, yes, development is 
> still active and alive. :)
>
>     https://git.gnu.io/gnu/gnu-fm
>
> I tried looking for contributing guidelines on the repository, but 
> ultimately, it came up pretty dry for me. More often than not, though, 
> I see people who wonder if they have the skills to contribute, usually 
> do. :) I would say your best bet is to follow all existing styling / 
> formatting in the project thus far, work on your improvements, and 
> submit them as pull requests after you've tested them.
>
> As a user and supporter of GNU FM / LibreFM, I hope to see your 
> contributions and improvements get into the project soon. Hopefully 
> there will be some others who might be able to chime in too with some 
> more advice, from those working in the project.
>
> --
> Cheers,
> Justin W. Flory
> address@hidden
Alrighty. Thanks for answering, and apologies for my late answer. I've 
created a pull request now, with some *basic* changes(syntax error fixes 
and such). Skimming through the code there were a bunch of other ideas 
that would be nice to implement, imho, like:
* changing from adodb to pdo
* bootstrapping
* refactoring the code f.ex regarding the User classes
* reorganizing the files as well, avoid having config data in public 
folders and such.

Also, I'm sure that something good can be made better! (Although I 
didn't see too many issues on gnu.io) I'm not sure I know the system 
well enough to start implementing new features yet :), but I'm trying to 
fix that..

Some dummy data or such for the database would be useful too, it would 
make it easier to test things. All I have now is an empty database.
/Regards, Torbjörn Stabo