Re: LT_AC_PROG_SED

[Robert Boehne]

Albert Chin wrote:
> 
> On Tue, Jan 29, 2002 at 05:00:04PM -0600, Robert Boehne wrote:
> > OK, I fixed this little problem and tested to prove the
> > changes.  Checking in to HEAD.
> 
> Index: libtool.m4
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/libtool.m4,v
> retrieving revision 1.246
> diff -u -3 -p -r1.246 libtool.m4
> --- libtool.m4  29 Jan 2002 22:58:35 -0000      1.246
> +++ libtool.m4  29 Jan 2002 23:09:58 -0000
> @@ -5371,12 +5375,6 @@ $debug ||
>      cat /dev/null > "$tmp/sed.in"
>      _count=0
>      echo $ECHO_N "0123456789$ECHO_C" >"$tmp/sed.in"
> -    # Check for GNU sed and select it if it is found.
> -    if "${_sed}" --version 2>&1 < /dev/null | egrep '(GNU)' > /dev/null;
> -then
> -      lt_cv_path_SED=${_sed}
> -      break;
> -    fi
>      while true; do
>        cat "$tmp/sed.in" "$tmp/sed.in" >"$tmp/sed.tmp"
>        mv "$tmp/sed.tmp" "$tmp/sed.in"
> 
> Why special-case GNU sed? And, if you decide to leave it in, the
> 'then' should be on the same line as the if.
> 
> --
> albert chin (address@hidden)

Albert:

I'm special-casing GNU sed so we don't have to go to
the bother of testing it.  On a slow machine this could
take a non-negligable amount of time.  We don't need to
test GNU sed because it won't truncate output.

As far as the extra newline before "then" I think that
was a mail-induced boo-boo, I'll fix it asap.

Rob

-- 
Robert Boehne             Software Engineer
Ricardo Software   Chicago Technical Center
TEL: (630)789-0003 x. 238
FAX: (630)789-0127
email:  address@hidden