Re: libjava "make install" silent failures

[Alexandre Oliva]

On Mar 15, 2002, Bryce McKinlay <address@hidden> wrote:

> The ltmain.sh patch also appears to fix the problem.

Great, here's what I'm checking in mainline and 3.1 branch.  It's a
slightly modified version of the patch that doesn't trigger an
sanity-check error in the libtool testsuite.

Other libtoolers, ok to install a very similar patch in libtool mainline
(and perhaps in the 1.4 branch, just in case)?

Index: ChangeLog
from  Alexandre Oliva  <address@hidden>

        * ltmain.sh (taglist): Initialized.  Don't let `CC' tag out of it.
        (relink_command): Added --tag flags.
        (mode=install): If relinking fails; error out.

Index: ltmain.sh
===================================================================
RCS file: /cvs/gcc/egcs/ltmain.sh,v
retrieving revision 1.17
diff -u -p -r1.17 ltmain.sh
--- ltmain.sh 2001/09/01 00:47:19 1.17
+++ ltmain.sh 2002/03/15 22:58:58
@@ -107,6 +107,7 @@ show_help=
 execute_dlfiles=
 lo2o="s/\\.lo\$/.${objext}/"
 o2lo="s/\\.${objext}\$/.lo/"
+taglist=
 
 # Parse our command line options once, thoroughly.
 while test $# -gt 0
@@ -140,6 +141,7 @@ do
       CC)
        # Don't test for the "default" C tag, as we know, it's there, but
        # not specially marked.
+       taglist="$taglist $tagname"
        ;;
       *)
         if grep "^### BEGIN LIBTOOL TAG CONFIG: $tagname$" < "$0" > /dev/null; 
then
@@ -4299,7 +4301,11 @@ fi\
        fi
       done
       # Quote the link command for shipping.
-      relink_command="cd `pwd`; $SHELL $0 --mode=relink $libtool_args"
+      tagopts=
+      for tag in $taglist; do
+        tagopts="$tagopts --tag $tag"
+      done
+      relink_command="(cd `pwd`; $SHELL $0$tagopts --mode=relink $libtool_args"
       relink_command=`$echo "X$relink_command" | $Xsed -e "$sed_quote_subst"`
 
       # Only create the output if not a dry run.
@@ -4605,7 +4611,7 @@ relink_command=\"$relink_command\""
          if $run eval "$relink_command"; then :
          else
            $echo "$modename: error: relink \`$file' with the above command 
before installing it" 1>&2
-           continue
+           exit 1
          fi
        fi
 

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  address@hidden, redhat.com}
CS PhD student at IC-Unicamp        address@hidden, gnu.org}
Free Software Evangelist                Professional serial bug killer