[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: Piecewise linking and export_symbols_cmds
From: |
gary |
Subject: |
Re: PATCH: Piecewise linking and export_symbols_cmds |
Date: |
Thu, 23 May 2002 13:11:04 +0100 |
User-agent: |
Demon-WebMail/2.0 |
address@hidden wrote:
>
> 2002-05-23 Robert Boehne <address@hidden>
> * ltmain.in (Piecewise linking): Add a clause to skip creating
> the export file until the reloadable object file(s) have been
> created, then use them as input for $export_symbols_cmds.
Looks good to me in principle, however I have a couple of nits:
> + if len=`expr "X$cmd" : ".*"` &&
> + test "$len" -le "$max_cmd_len" || test "$max_cmd_len" -le -1;
> then
test "$len" -lt "$max_cmd_len" || ... # (inconsequential?) off by one error
> + $show "$cmd"
> + $run eval "$cmd" || exit $?
> + else
> + # The command line is too long to execute in one step.
> + $echo "using reloadable object files..."
$show "using..." ?? # otherwise -quiet doesn't work well
> + skipped_export="YES"
skipped_export=: # we use : and false for boolean values in libtool
> + fi
Admittedly it doesn't help much here:
> + if test "X$skipped_export" != "XYES" && len=`expr "X$cmds" : ".*"` &&
if test "X$skipped_export" != "X:" && ...
But it is useful here:
> + if test "X$skipped_export" = "XYES" ; then
if ${skipped_export-false}; then
+ $show "generating symbol list for \`$libname.la'"
+ export_symbols="$output_objdir/$libname.exp"
+ $run $rm $export_symbols
+ libobjs=$output
+ echo "\$libobjs is currently set to $libobjs"
$show "\$libobjs..." # for --quiet
+ # Append the command to create the export file.
+ eval concat_cmds=\"\$concat_cmds~$export_symbols_cmds\"
+ fi
Cheers,
Gary.
--
())_. Gary V. Vaughan gary@(oranda.demon.co.uk|gnu.org)
( '/ Research Scientist http://www.oranda.demon.co.uk ,_())____
/ )= GNU Hacker http://www.gnu.org/software/libtool \' `&
`(_~)_ Tech' Author http://sources.redhat.com/autobook =`---d__/