libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] change linux* in AC_DEPLIBS_CHECK_METHOD to pass_all


From: Scott James Remnant
Subject: [PATCH] change linux* in AC_DEPLIBS_CHECK_METHOD to pass_all
Date: Mon, 22 Sep 2003 20:08:18 +0100

We trip over this every time we add a new architecture to Debian,
file_magic just does not do the right thing on Linux leading to broken
shared libraries (most particularly, GTK+) on some of the more
interesting architectures.

The only case for file_magic given (glibc <= 2.1.1 on ARM) is believed
by the ARM buildd maintainer to be an invalid one -- especially given
that the same file_magic breaks current ARM Linux.  (He also points out
that, to his knowledge, the only Linux ARM distribution to ever ship
glibc <= 2.1.1 was Debian, and we stopped doing that a LONG time ago).

We've been shipping Debian libtool (both 1.4 and 1.5) with this patch
for some time, and never encountered a problem.  It effectively brings
linux* to the same state as gnu* -- use pass_all for everything.

I've written the patch to keep the older code, as is done in a few other
places in the same macro, overriding with pass_all afterwards.

Scott
-- 
Have you ever, ever felt like this?
Had strange things happen?  Are you going round the twist?
diff -ruNp libtool-1.5~/ChangeLog libtool-1.5/ChangeLog
--- libtool-1.5~/ChangeLog      2003-04-14 23:48:00.000000000 +0100
+++ libtool-1.5/ChangeLog       2003-09-22 19:59:36.000000000 +0100
@@ -0.0 +1,6 @@
+2003-09-22  Scott James Remnant  <address@hidden>
+
+       * libtool.m4: Use pass_all for linux* solving many build
+       problems on ARM, and hopefully preventing any future ones.
+       (Debian Bug #191133 and #190569)
+       
diff -ruNp libtool-1.5~/libtool.m4 libtool-1.5/libtool.m4
--- libtool-1.5~/libtool.m4     2003-04-14 22:58:23.000000000 +0100
+++ libtool-1.5/libtool.m4      2003-09-22 19:53:50.000000000 +0100
@@ -2166,6 +2166,7 @@ irix5* | irix6* | nonstopux*)
 
 # This must be Linux ELF.
 linux*)
+  # this will be overridden with pass_all, but let us keep it just in case
   case $host_cpu in
   alpha* | hppa* | i*86 | ia64* | m68* | mips | mipsel | powerpc* | sparc* | 
s390* | sh*)
     lt_cv_deplibs_check_method=pass_all ;;
@@ -2174,6 +2175,7 @@ linux*)
     lt_cv_deplibs_check_method='file_magic ELF [[0-9]][[0-9]]*-bit [[LM]]SB 
(shared object|dynamic lib )' ;;
   esac
   lt_cv_file_magic_test_file=`echo /lib/libc.so* /lib/libc-*.so`
+  lt_cv_deplibs_check_method=pass_all
   ;;
 
 netbsd*)

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]