[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Formatting fixes to ltmain.in for branch-1-5
From: |
Albert Chin |
Subject: |
Re: Formatting fixes to ltmain.in for branch-1-5 |
Date: |
Thu, 12 Feb 2004 11:21:46 -0600 |
User-agent: |
Mutt/1.4i |
On Thu, Feb 12, 2004 at 04:52:44PM +0000, Scott James Remnant wrote:
> On Sun, 2004-02-08 at 23:15, Albert Chin wrote:
>
> > 2004-02-08 Albert Chin-A-Young <address@hidden>
> >
> > * ltmain.in: Indentation fixes, typo fixes.
> >
> There's quite a few problems with this patch; in a few places you break
> a single-line if statement up into multiple lines without appending "\"
> onto the end of the lines.
Libtool is inconsistent in this. I just picked one I saw and used it
accordingly. Search for '||$' in ltmain.in in libtool-1.5.2.tar.gz and
you'll find:
if test -z "$pic_object" || \
test -z "$non_pic_object" ||
test "$pic_object" = none && \
test "$non_pic_object" = none; then
$echo "$modename: cannot find name of object for \`$arg'" 1>&2
exit 1
fi
if test -z "$pic_object" || \
test -z "$non_pic_object" ||
test "$pic_object" = none && \
test "$non_pic_object" = none; then
$echo "$modename: cannot find name of object for \`$arg'"
1>&2
exit 1
fi
if test "$linkmode,$pass" = "lib,link" ||
test "$linkmode,$pass" = "prog,scan"; then
libs="$deplibs"
deplibs=
fi
if test "$linkmode,$pass" = "lib,link" ||
test "$linkmode,$pass" = "prog,scan" ||
{ test "$linkmode" != prog && test "$linkmode" != lib; }; then
test -n "$dlopen" && dlfiles="$dlfiles $dlopen"
test -n "$dlpreopen" && dlprefiles="$dlprefiles $dlpreopen"
fi
if test "$link_all_deplibs" != no || test -z "$library_names" ||
test "$build_libtool_libs" = no; then
linkalldeplibs=yes
fi
etc.
--
albert chin (address@hidden)