[PATCH] libltdl: don't dlopen libraries with the GLOBAL flag

[Scott James Remnant]

This was discussed on bug-libtool, and the consensus seemed to be that
we shouldn't be doing this.  For the bug, see:

http://mail.gnu.org/archive/html/bug-libtool/2004-03/msg00094.html


Okay to apply?

Scott
-- 
Have you ever, ever felt like this?
Had strange things happen?  Are you going round the twist?

diff -ruNp libtool-CVS~/ChangeLog libtool-CVS/ChangeLog
--- libtool-CVS~/ChangeLog      2004-03-24 03:14:19.000000000 +0000
+++ libtool-CVS/ChangeLog       2004-03-24 03:18:48.000000000 +0000
@@ -0,0 +1,6 @@
+2004-03-24  Scott James Remnant  <address@hidden>
+
+       * libltdl/ltdl.c (sys_dl_open): Don't load libraries with global
+       symbol resolution.
+       * NEWS: Updated.
+
diff -ruNp libtool-CVS~/libltdl/ltdl.c libtool-CVS/libltdl/ltdl.c
--- libtool-CVS~/libltdl/ltdl.c 2004-01-16 22:03:19.000000000 +0000
+++ libtool-CVS/libltdl/ltdl.c  2004-03-24 03:16:04.000000000 +0000
@@ -1033,17 +1033,6 @@ lt_estrdup (str)
 #  include <sys/dl.h>
 #endif
 
-#ifdef RTLD_GLOBAL
-#  define LT_GLOBAL            RTLD_GLOBAL
-#else
-#  ifdef DL_GLOBAL
-#    define LT_GLOBAL          DL_GLOBAL
-#  endif
-#endif /* !RTLD_GLOBAL */
-#ifndef LT_GLOBAL
-#  define LT_GLOBAL            0
-#endif /* !LT_GLOBAL */
-
 /* We may have to define LT_LAZY_OR_NOW in the command line if we
    find out it does not work in some platform. */
 #ifndef LT_LAZY_OR_NOW
@@ -1079,7 +1068,7 @@ sys_dl_open (loader_data, filename)
      lt_user_data loader_data;
      const char *filename;
 {
-  lt_module   module   = dlopen (filename, LT_GLOBAL | LT_LAZY_OR_NOW);
+  lt_module   module   = dlopen (filename, LT_LAZY_OR_NOW);
 
   if (!module)
     {
diff -ruNp libtool-CVS~/NEWS libtool-CVS/NEWS
--- libtool-CVS~/NEWS   2004-03-21 16:05:28.000000000 +0000
+++ libtool-CVS/NEWS    2004-03-24 03:17:41.000000000 +0000
@@ -37,6 +37,7 @@ New in 1.5b: 2004-??-??; CVS version 1.5
 * Speed up max_cmd_len check.
 * New function in libltdl: lt_dlhandle_find provides access to module handles
   by module name.
+* libltdl no longer loads shared libraries with global symbol resolution.
 * make install now deletes preexisting $prefix/share/libtool before installing
   latest files.
 * Extracting symbols from an import library on cygwin and win32 now works.

signature.asc
Description: This is a digitally signed message part