libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libtool--gary--1.0--patch-36


From: Gary V. Vaughan
Subject: Re: libtool--gary--1.0--patch-36
Date: Mon, 09 Aug 2004 15:27:41 +0100
User-agent: Mozilla Thunderbird 0.7 (X11/20040615)

Hi Peter,

Thanks for reviewing the patch :-)

Peter O'Gorman wrote:
> Gary V. Vaughan wrote:
>> Index: Changelog
>> from  Gary V. Vaughan  <address@hidden>
>>
>>     The Grand Renaming.  In preparation for libtool-2.0, move all of
> 
> []
> 
>>
>> 2004-08-06  Gary V. Vaughan  <address@hidden>
>>
>>     * libltdl/ltdl.c (lt_dlforeachfile): LT_SYS_LIBSEARCH_PATH is not
>>     an environment variable, it is an actual path.
>>     Reported by Noah Mish <address@hidden>
>
> So there are two separate patches in here?

No, that's tlaapply picking up differences in the ChangeLog -- I forgot to
credit Noah in the previous changelog entry and added post-facto, and possibly
the dates for that patch are not identical between libtool--devo and
libtool--gary.  tlaapply just applies gnudiff dumbly, and doesn't know
anything about ChangeLogs as such.

>> address@hidden LT_CMD_MAX_LEN
>> +Finds the longest command line that can be safely passed to
>> address@hidden without being truncated, and store in the shell variable
>> address@hidden  It is only approximate an approximate value, but
> 
> 
> I think you only want the second approximate.

Thanks.  Done!

>> +Macros in the @samp{LT_FUNC_} namespace check characteristics of
>> +librory functions:
>  
> I think you'll notice the librory in there... library :)

D'oh.  Thanks again.

>> address@hidden LT_SYS_SYMBOL_USCORE
>> +Set the shell variable @samp{sys_symbol_underscore} to @samp{no}
>> +unless the compiler prefixes global symbols with an underscore.
>> address@hidden defmac
> 
> 
> Maybe add a note that this is not the same thing as testing if dlsym
> requries an underscore. At least on darwin these are different. There is
> an underscore in symbol names, but dlsym does not need one.

Okay, will do.

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]