Re: eval $show when we $run eval

[Gary V. Vaughan]

Hi Peter,

Peter O'Gorman wrote:
> Okay to commit?

Not quite....

> Index: ChangeLog
> 2004-10-13  Peter O'Gorman  <address@hidden>
> 
>       * config/ltmain.m4sh: Make sure that we $show what we will $run,
>       use eval $show if we do $run eval.

> -      $show "$command"
> +      eval $show "$command"

eval will strip the quotes, so that $show will run on the bare $command
expansion, which may contain chars special to the shell, e.g ;

I think the changed lines should read (untested!):

    eval \$show \"$command\"

Hmmm.... maybe $command contains " marks too :-(  If that is a possibility
then $command must be passed through func_quote_for_eval():

    func_quote_for_eval "$command"
    eval \$show \"$func_quote_for_eval_result\"

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature