Re: libtool problem on FreeBSD 4.1 with -pthread

[Noah Misch]

On Mon, Nov 08, 2004 at 10:55:19AM +0100, Ralf Wildenhues wrote:
> * Peter Ekberg wrote on Sat, Nov 06, 2004 at 05:29:25PM CET:
> > Peter O'Gorman wrote:
> > > 
> > > If you put it in the .la in $inherited_linker_flags then all should
> > > be well (I think).

> I think we should take it, even if:
> 
> - On AIX, users will still have to set their compiler.

Agreed.

> - For different compilers on the same system, different flags might be
> necessary.  Thus, if you compile the library with a different

This seems like an acceptable trade-off.

> - Other than the second point, this approach is orthogonal to finding
> out the value of thread_safe_flag_spec.

> What do the others think?  I don't want to have the last word here.

A build system for a program that uses threads should compile _every_ _source_
_file_ with platform-appropriate CPPFLAGS (e.g. -D_REENTRANT -D_THREAD_SAFE).
-pthread takes care of this where it is available.  Given that, libtool does not
make a threads-naive build recipe appropriate for threaded operation by merely
propagating -pthread in the final link line.  I do not think this patch
increases the number of situations in which libtool will do the right thing.

The ggi build process already supplies the requisite preprocessor flags.  As
best I can tell, it just needs to also pass -pthread on link in demos/, just as
it does elsewhere.

I see that you have already committed the patch; sorry for the lateness.