Re: fix testsuite with support for -I in libtoolize [libtool--gary--1.0--patch-61]

[Gary V. Vaughan]

Hi Peter!

Peter O'Gorman wrote:
> Gary V. Vaughan wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Okay to commit?
> 
> 
> No, sorry. I think LIBTOOLIZE needs to be an exported environment
> variable for autoreconf (otherwise we'll get crap from the installed
> libtool at autoreconf time),

Ah, okay.  Good catch, thanks.

I don't think this can be fixed properly though since the -I flags are
needed to get the testsuite not to use an earlier installed /usr/local/share
tree for macros and libltdl sources.  It looks like autoreconf will
handle LIBTOOLIZE with embedded arguments unless any of the paths contain
spaces when it will go horribly wrong.

On the other hand, running the a test with ../tests/testsuite -v -x 1
doesn't throw any spurious messages from autoreconf.  Perhaps the manual
libtoolize call before satisfies the dependencies?  If not, then I suggest
we run libtoolize manually (as now), but set LIBTOOLIZE=: in the environment
of the following autoreconf invocation.  Don't forget that
tests/testsuite.dir/1 is deleted when the test is done, so the user and
the makefiles shouldn't ever try to autoreconf a populated tree.

> as well as Ralf's concerns about the AT_
> namespace issues.

That is orthogonal.

> libtool: Version mismatch error.  This is libtool 1.9g, but the
> libtool: definition of this LT_INIT comes from libtool 2.1a.
> libtool: You should recreate aclocal.m4 with macros from libtool 1.9g
> libtool: and run autoconf again.
> make[1]: *** [subdir/sub.lo] Error 1

Thanks for the review!

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature