Re: Libtool-patches Digest, Vol 25, Issue 12

[Ralf Wildenhues]

It's unfortunate that replying to digests breaks subject, threading and
attribution.  Is this a mailing list handler issue or a client one
(I know there are setups that can do this correctly)?

* Akim Demaille wrote on Wed, Dec 08, 2004 at 09:23:38AM CET:
> >>> "libtool-patches-request" == libtool-patches-request  <address@hidden> 
> >>> writes:
> 
>  > @@ -1493,8 +1498,8 @@
>  >        *.lo)
>  >    # Just add the directory containing the .lo file.
>  > -  dir=`$ECHO "X$file" | $Xsed -e 's%/[[^/]]*$%%'`
>  > -  test "X$dir" = "X$file" && dir=.
>  > +  func_dirname "$file" "" "."
>  > +  dir="$func_dirname_result"
>  >    ;;
>  
>  >        *)
> 
> I don't understand why you don't write functions that send their
> result on stdout.  That would be more readable.  Are there any
> portability issues?  Is it because of embedded quotes?  Here there
> don't seem to be any problem.
> 
>             dir=`func_dirname "$file" "" "."`

It's a lot faster because you don't fork.
This is a speed/readability trade-off in this case (there might be other
cases where embedded quotes are an issue, but I think none in libtool
right now).  My change does not penalize either old nor new shells.

Regards,
Ralf