Re: put slist in ltdl namespace

[Gary V. Vaughan]

Ralf Wildenhues wrote:
> This is just a gentle reminder for Gary that, when he comes back,
> he needs to look at this and decide whether it's ok like this.

Hallo Ralf!

> (Probably either the prefix should be lt_, or strl* should have prefix
> lt__ as well, but I haven't grokked Gary's idea of what the namespaces
> ought to be.)

If the symbols are available to clients of libltdl, then the prefix should
be 'lt_', if they are only exported for internal use then 'lt__' is used.

By that definition, since strl* are not designed for use by libltdl clients
(as evidenced by being declared in an uninstall lt__strl.h header), they
should be using symbols with a 'lt__' prefix.  Technically the slist and
argz filenames should also be 'lt__' prefixed, but doing that would make
it harder to use them outside libtool.

Actually, lt__strl* should be documented as being part of the same api
layer as lt__dirent* and lt__alloc* in the HACKING file.  Maybe we should
split lt__strl.c into strlcpy.c and strlcat.c and change the symbol
renaming stuff in lt__strl.h to conform with the way argz is handled so
that it can be exported to gnulib... anyway, that is a separate issue.

>       * libltdl/libltdl/slist.h: For libltdl, move all exported
>       symbols into the lt__* namespace.

Agreed in principle, but the renames should be done in lt__glibc.h, as slist.h
is implemented at the same api layer as argz.h.  Don't forget to remove the
#include <slist.h> from lt__private.h too.

Unfortunately this means that the names of the api layers are not very good
:-(  slist is not an implementation of glibc functionality, so lt__glibc.h
needs to be renamed to avoid that confusion.  Perhaps lt__symbols.h?  Again,
this is a separate issue.  I'll think about a patch presently.

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature