libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: function definitions


From: Gary V. Vaughan
Subject: Re: FYI: function definitions
Date: Tue, 01 Feb 2005 13:41:59 +0000
User-agent: Mozilla Thunderbird 0.9 (X11/20041103)

Hallo Ralf1

Ralf Wildenhues wrote:
> My understanding was that Autoconf should get a new macro that then
> provided this.  Using the internal interface _AS_CR_PREPARE is wrong.
> 
> * Gary V. Vaughan wrote on Tue, Feb 01, 2005 at 12:49:29PM CET: 
> > On branch-2-0, I think the following is fairly future proof:
> >
> > test -n "$as_cr_alnum" || as_cr_alnum='abcdef...XYZ0123456789'
> >
> > In both cases, I think the slight untidiness is worth the extra safety added
> > to sh.test...  what do you think?
> 
> In both cases it is plain easier if I write
>   lt_cr_alnum=abcdef...89
> and be done with it.  I don't even need a variable here.  I really don't
> need to abstract out anything here, and IMNSHO this whole discussion is
> much longer than what the problem at hand deserves.

Good point.  I was getting hung up on keeping a tie into the autoconf
definition incase future releases are internationalised or something.
But you're right:  it's definitely overkill in this case :-)

In any case, I think adding the extra check to sh.test would be a good
thing -- however the expression is constructed.

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]