[PATCH] Adding dirs for installed libraries to temp_rpath is breaking builds on darwin8

[Peter O'Gorman]

Hi,
Some members of the Fink project <http://fink.sourceforge.net> have access 
to prerelease versions of Apple's Mac OS X 10.4 (Tiger). While building 
packages on the prerelease OS it was discovered that Apple, in its infinite 
wisdom, has required that a certain, very common, library be available when 
launching pretty much any application. Apple has a strange version of this 
very common library, so not all replacements will do.

If there is a lib with the same name as the aforementioned lib in 
DYLD_LIBRARY_PATH then nothing can be launched. This is breaking many fink 
packages builds :(

Bad Apple!

Okay to apply (all branches, patch against branch-1-5)?

Peter
--
Peter O'Gorman - http://www.pogma.com

Index: ChangeLog
2005-02-01  Peter O'Gorman  <address@hidden>

        * ltmain.in [darwin]: Don't add installed libs to temp_rpath when
        building executables on darwin.

from  Ralf Wildenhues  <address@hidden>
Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v
retrieving revision 1.334.2.52
diff -u -3 -p -u -r1.334.2.52 ltmain.in
--- ltmain.in 1 Feb 2005 07:35:38 -0000 1.334.2.52
+++ ltmain.in 1 Feb 2005 15:14:22 -0000
@@ -2222,6 +2222,8 @@ EOF
        # it will not redefine variables installed, or shouldnotlink
        installed=yes
        shouldnotlink=no
+       avoidtemprpath=
+
 
        # Read the .la file
        case $lib in
@@ -2320,6 +2322,9 @@ EOF
            dir="$libdir"
            absdir="$libdir"
          fi
+         case $host in
+           *darwin*) avoidtemprpath=yes ;;
+         esac
        else
          if test ! -f "$ladir/$objdir/$linklib" && test -f 
"$abs_ladir/$linklib"; then
            dir="$ladir"
@@ -2404,7 +2409,7 @@ EOF
          if test -n "$library_names" &&
             { test "$prefer_static_libs" = no || test -z "$old_library"; }; 
then
            # We need to hardcode the library path
-           if test -n "$shlibpath_var"; then
+           if test -n "$shlibpath_var" && test -z "$avoidtemprpath" ; then
              # Make sure the rpath contains only unique directories.
              case "$temp_rpath " in
              *" $dir "*) ;;