Re: FYI: make libtoolize's pkgvdatadir a private api [libtool--devo--1.0--patch-105]

[Gary V. Vaughan]

Ralf Wildenhues wrote:
> Hi Gary,

Hallo Ralf!

> OK to apply this fix?

In principle I like the patch, but I wonder if we should abstract out
the setting of _lt_pkgvdatadir so that it is exported to the environment
for the duration of the whole testsuite?

If you agree, then I think we should also change the name (again), and
maybe make it a documented public interface: LIBTOOLIZE_PATH?

In the meantime, if you want to apply this to HEAD while we discuss the
final details, then please go ahead.

Cheers,
        Gary.

> Index: tests/testsuite.at
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v
> retrieving revision 1.9
> diff -u -r1.9 testsuite.at
> --- tests/testsuite.at        4 Apr 2005 17:24:40 -0000       1.9
> +++ tests/testsuite.at        5 Apr 2005 08:01:14 -0000
> @@ -43,7 +43,7 @@
>  m4_define([LT_AT_BOOTSTRAP],
>  [
>  test -f ./ltmain.sh || LT_AT_LIBTOOLIZE([--copy])
> -test -f ./configure || autoreconf --force --verbose --install
> +test -f ./configure || _lt_pkgvdatadir="$abs_top_srcdir" autoreconf --force 
> --verbose --install
>  test -f ./configure || exit 1
>  ./configure
>  ])


--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature