libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: Libtool head: standalone.at test should use $(CFLAGS)


From: Peter Ekberg
Subject: RE: Libtool head: standalone.at test should use $(CFLAGS)
Date: Thu, 25 Aug 2005 15:16:16 +0200

Ralf Wildenhues wrote:
> Hi Peter,
> 
> * Peter Ekberg wrote on Thu, Aug 25, 2005 at 11:05:40AM CEST:
> > 
> > I discovered a linking problem in the testsuite with my MSVC
> > patch, and have found the attached solution...
> > 
> > 2005-08-25  Peter Ekberg  <address@hidden>
> > 
> >     * tests/standalone.at: (without autotools): Add
> >     $(CFLAGS) to LTCOMPILE and LTLINK.
> 
> OK, but I see the need for even more changes: we want $(INCLUDES)
> earlier, and we want --tag=CC as well, similar to what Autoconf emits:
> 
> LTCOMPILE = $(LIBTOOL) --tag=CC $(LIBTOOLFLAGS) --mode=compile \
>         $(CC) $(INCLUDES) $(CPPFLAGS) $(CFLAGS)

Ok.

*snip*

> > Isn't the following Makefile snippet from tests/standalone.at
> > in violation, as it compiles main.c and links ltdldemo in one
> > go?
> 
> I believe so.  Could you be bothered to produce a fix?

Certainly, an attempt is attached. BTW, should not -no-undefined
be added somewhere?

2005-08-25  Peter Ekberg  <address@hidden>
            Ralf Wildenhues  <address@hidden>

        * tests/standalone.at: (without autotools): Add
        $(CFLAGS) to LTCOMPILE and LTLINK. Separate compiling
        and linking. Remove compiling flags from link. Add
        --tag.

Attachment: head-standalone-flags-2.patch
Description: head-standalone-flags-2.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]