libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Libtool stresstest: echo marker with loop variables


From: Ralf Wildenhues
Subject: Re: Libtool stresstest: echo marker with loop variables
Date: Wed, 21 Sep 2005 11:17:33 +0200
User-agent: Mutt/1.4.1i

Hi Peter,

* Peter Ekberg wrote on Tue, Sep 20, 2005 at 12:07:00PM CEST:
> * Ralf Wildenhues wrote on Monday, September 19, 2005 19:22 CEST:
> 
> > I have not changed any of the actual stuff to test yet.  But the next
> > useful thing would be to copy $top_builddir/libtool to the test dir,
> > adjust $LIBTOOL, and set max_cmd_len so low that the
> > piecewise/reload/bla stuff all triggers, as done in pdemo.
> 
> Yes, that will probably trigger some bugs...

This patch gets you a start at triggering.  Without the change to ltmain
some failures are silent again; again this patch is obviously not ready
or meant for inclusion the way it is now, just for exposing bugs.  :)
It triggers the "non-existing $export_symbols in case of reloadable
objects" on every system, AFAICS.
(You may have to add more failure-exposing patches.)

And by the way, my last proposed stresstest rework from yesterday errs
wrt. shell quoting and just happens to work by chance.  And is generally
ugly, too.  Oh well..

Cheers,
Ralf

Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.8
diff -u -r1.8 ltmain.m4sh
--- libltdl/config/ltmain.m4sh  17 Sep 2005 07:38:28 -0000      1.8
+++ libltdl/config/ltmain.m4sh  21 Sep 2005 09:06:46 -0000
@@ -4959,9 +4959,9 @@
            done
            IFS="$save_ifs"
            if test -n "$export_symbols_regex"; then
-             func_show_eval '$EGREP -e "$export_symbols_regex" 
"$export_symbols" > "${export_symbols}T"'
-             func_show_eval '$MV "${export_symbols}T" "$export_symbols"'
+             func_show_eval '$EGREP -e "$export_symbols_regex" 
"$export_symbols" > "${export_symbols}T"' 'exit $?'
+             func_show_eval '$MV "${export_symbols}T" "$export_symbols"' 'exit 
$?'
            fi
          fi
        fi
 
Index: tests/stresstest.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/stresstest.at,v
retrieving revision 1.6
diff -u -r1.6 stresstest.at
--- tests/stresstest.at 13 Sep 2005 07:28:14 -0000      1.6
+++ tests/stresstest.at 21 Sep 2005 09:06:47 -0000
@@ -25,6 +25,11 @@
 AT_SETUP([Link option thorough search test])
 eval `$LIBTOOL --config | $EGREP '^(CC|objdir)='`
 
+rm -f libtool
+sed 's/^max_cmd_len=*/max_cmd_len=24 # /g' $LIBTOOL > libtool
+chmod +x libtool
+LIBTOOL=./libtool
+
 mkdir sub sub2 sub3 2>/dev/null
 
 AT_DATA(a.c,




reply via email to

[Prev in Thread] Current Thread [Next in Thread]