[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 280-gary-test-old-m4-interface.diff

From: Gary V. Vaughan
Subject: Re: 280-gary-test-old-m4-interface.diff
Date: Thu, 29 Sep 2005 17:10:47 +0100
User-agent: Mozilla Thunderbird 1.0 (X11/20050305)

Hi Peter,

Thanks for the review!


Peter Ekberg wrote:
On Thu, Sep 29, 2005 at 03:35:37PM +0100, Gary V. Vaughan wrote:
+all: address@hidden@
address@hidden@: address@hidden@
+       $(LINK) address@hidden@
+       $(COMPILE) -c $<

Can we not use libtool compile/link mode instead so that the
test does not break with my MSVC patches? I mean, since the
test is for the m4 interface, or is this somehow part of the
m4 interface?

No it isn't part of the m4 interface, but neither does it build
or link with any libraries/library objects.  I'm not sure it would
be correct to call libtool in that case.  How do your MSVC patches
cope with compiling regular objects and linking regular executables?
Can you suggest what you think I should be doing here?

The other issue I found was the checking of stdout, which does not
seem to be portable, but I think Ralf covered that in his review.

I think Ralf just meant that I wasn't checking the return status
of lt_dlexit().  Why is checking stdout non-portable?

Gary V. Vaughan      ())_.  address@hidden,}
Research Scientist   ( '/
GNU Hacker           / )=
Technical Author   `(_~)_

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]