[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch 15/19] 299-gary-refactor-autotests.diff Queue
|
From: |
Gary V. Vaughan |
|
Subject: |
Re: [patch 15/19] 299-gary-refactor-autotests.diff Queue |
|
Date: |
Mon, 10 Oct 2005 16:46:34 +0100 |
|
User-agent: |
Mozilla Thunderbird 1.0 (X11/20050305) |
Ralf Wildenhues wrote:
Hi Gary,
Hallo Ralf,
Approved (after its requirements are in, if any), except for one nit,
see below inline.
Okay, thanks.
Oh, if you were bored, you could
_LTDL_PROJECT_FILES([with-or-without-Makefile])
but really I don't care.
Okay, I've made it into _LTDL_PROJECT_FILES([LDTL-DIR])
-LT_AT_LIBTOOLIZE([--copy --ltdl])
+_LTDL_PROJECT_FILES
+LT_AT_LIBTOOLIZE([--copy --ltdl=sub/ltdl])
Why did you change `--ltdl' to `--ltdl=sub/ltdl' here?
IMO better to leave as-is, unless there is a compelling reason against
it. (We have to support plain `--ltdl' for backward compatibility.)
Because the Makefile in _LTDL_PROJECT_FILES used to hardcode
sub/ltdl. Now fixed.
Cheers,
Gary.
--
Gary V. Vaughan ())_. address@hidden,gnu.org}
Research Scientist ( '/ http://tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/libtool
Technical Author `(_~)_ http://sources.redhat.com/autobook
signature.asc
Description: OpenPGP digital signature
- [patch 11/19] 295-gary-dont-force-ac-config-headers-on-subproject-ltdl.diff Queue, (continued)
- [patch 11/19] 295-gary-dont-force-ac-config-headers-on-subproject-ltdl.diff Queue, Gary V. Vaughan, 2005/10/10
- [patch 12/19] 296-gary-ltdl-recursive-tests.diff Queue, Gary V. Vaughan, 2005/10/10
- [patch 14/19] 298-gary-document-libltdl-build-modes.diff Queue, Gary V. Vaughan, 2005/10/10
- [patch 15/19] 299-gary-refactor-autotests.diff Queue, Gary V. Vaughan, 2005/10/10
- [patch 16/19] 1-ralf-fix-ltdl-config-dist.diff Queue, Gary V. Vaughan, 2005/10/10
- [patch 17/19] 287-gary-implicit-libtoolize-ltdl.diff Queue, Gary V. Vaughan, 2005/10/10
- [patch 18/19] 300-gary-simplify-tests.diff Queue, Gary V. Vaughan, 2005/10/10