[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: darwin: mix up of .dylib and .bundle
From: |
Christoph Egger |
Subject: |
Re: darwin: mix up of .dylib and .bundle |
Date: |
Mon, 17 Oct 2005 15:11:53 +0200 (MEST) |
> [ taking out bug-libtool ]
>
> Hi Christoph, Peter,
>
> * Christoph Egger wrote on Sun, Oct 16, 2005 at 07:58:39PM CEST:
> > > Christoph Egger wrote:
> > > >
> > > file -L /path/to/with/ggbundle/in/it | grep bundle will return true!
> > >
> > > Let me look into a patch, probably testing for 'Mach-O bundle' is
> > > better than testing for 'bundle'.
> >
> > I've attached a patch, which fixes this bug.
> > I also added comments (two lines) which explains what it does and why.
> > libtool no longer needs to worry about any directory names.
>
> A couple of random thoughts:
>
> With the sed in place, should not grepping for `bundle' suffice?
>
> A casual glance at my "magic" file suggests the possibility of
> `Mach-O '
> `Mach-O fat file '
> `Macintosh MacBinary data ' (commented out)
>
> before the `bundle'. This might be completely unrealistic, but I don't
> know darwin at all, so darwin experts please decide. :)
>
> Also, can't we eliminate the extra process? How about a grep for
> `: [^:]* bundle' instead, given above? (Watch out, ltmain.m4sh needs
> the brackets m4-quoted!)
I tried this and it works, too.
Patch attached.
Please review and decide whether to apply this or the previous version :)
--
Greetings,
Christoph
Highspeed-Freiheit. Bei GMX supergünstig, z.B. GMX DSL_Cityflat,
DSL-Flatrate für nur 4,99 Euro/Monat* http://www.gmx.net/de/go/dsl
ltmain.m4sh.diff
Description: Binary data