libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

About the use of ${wl} ...


From: Kean Johnston
Subject: About the use of ${wl} ...
Date: Mon, 31 Oct 2005 08:00:40 -0800
User-agent: Mozilla Thunderbird 1.0.7 (Windows/20050923)

This should most likely go to the main list but since we've
had at least one patch that was relating to it, just a comment
on how $(wl} is used. Its a cosmetic thing, so its no big deal.

If you find youself having to make changes to things that
use ${wl}, consider consolidating the arguments. It makes some
long lines a bit shorter, and can read better. -Wl takes any
number of comma-separated arguments and expands them out
correctly when invoking the link editor. So instead of:

  some_variable="${wl}-h ${wl}$soname"

you can use:

  some_variable="${wl}-h,$soname"

Although there are no cases I have seen thus far that would be
affected, this is also a bit safer, as it guarantees that the
correct arguments travel with the correct options. At least at
one point in its lifetime, libtool would rewrite command lines
and if you happen to split along the incorrect boundary you
could land in a world of trouble.

Like I said, its just cosmetic, but then my brain was compiled
with -pedantic :)

Kean




reply via email to

[Prev in Thread] Current Thread [Next in Thread]