libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch 05/19] 288-gary-ltdl-nonrecursive-tests.diff Queue


From: Ralf Wildenhues
Subject: Re: [patch 05/19] 288-gary-ltdl-nonrecursive-tests.diff Queue
Date: Wed, 2 Nov 2005 14:18:54 +0100
User-agent: Mutt/1.5.11

* Gary V. Vaughan wrote on Tue, Nov 01, 2005 at 04:04:56PM CET:
> Ralf Wildenhues wrote:
> >Ho Gary,
> 
> Ho Ralf

Buon giorno Gary,

> (what language are we greeting each other in now btw?),

No idea what that was.  Sure worked, tho. ;)

> >>Okay to commit?
> >
> >Yes, please, after addressing these two nits:
> >- accommodate for Makefile.inc changes (AM_CPPFLAGS and AM_LDFLAGS)
> 
> Have I missed an instance?  I thought that was all taken care of in
> my latest patch revisions?  All tests pass with this patch applied to
> current HEAD...

If I apply this exact patch which you posted in 
http://lists.gnu.org/archive/html/libtool-patches/2005-10/msg00132.html
then I get
|    Subject: [libtool 2.1a] testsuite: 26 27 28 failed

| ../../libtool/tests/nonrecursive.at:69: if test -f libltdl/configure.ac; then 
false; fi
| ../../libtool/tests/nonrecursive.at:76: $ACLOCAL -I libltdl/m4
| stderr:
| stdout:
| ../../libtool/tests/nonrecursive.at:77: $AUTOHEADER
| stderr:
| stdout:
| ../../libtool/tests/nonrecursive.at:78: $AUTOMAKE --add-missing --copy
| stderr:
| libltdl/Makefile.inc:29: AM_CPPFLAGS must be set with `=' before using `+='
| Makefile.am:13:   `libltdl/Makefile.inc' included from here
| libltdl/Makefile.inc:32: AM_LDFLAGS must be set with `=' before using `+='
| Makefile.am:13:   `libltdl/Makefile.inc' included from here

which may be fixed with

--- tests/nonrecursive.at       2005-11-02 13:34:53.000000000 +0100
+++ tests/nonrecursive.at       2005-10-26 18:21:10.000000000 +0200
@@ -49,6 +49,9 @@
 CLEANFILES             =
 MOSTLYCLEANFILES       =
 
+AM_CPPFLAGS           =
+AM_LDFLAGS             =
+
 include libltdl/Makefile.inc
 
 foo_la_LDFLAGS         = -module -avoid-version


So I ask you to make this change and apply this patch together with all
the then-freed queue.  Thank you :)

Cheers,
Ralf

> >>Index: libtool--devo--1.0/ChangeLog
> >>from  Gary V. Vaughan  <address@hidden>
> >>       * tests/nonrecursive.at: New tests for libltdl as a subdirectory,
> >>       configured and compiled from the toplevel project.
> >>       * tests/testsuite.at: Use it.
> >>       (LT_AT_AUTOHEADER): New macro.
> >>       * Makefile.am (TESTSUITE_AT): Depend on nonrecursive.at.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]