libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libtoolize --ltdl non-failure


From: Gary V. Vaughan
Subject: Re: libtoolize --ltdl non-failure
Date: Thu, 17 Nov 2005 16:30:51 +0000
User-agent: Mozilla Thunderbird 1.0 (X11/20050305)

Hallo Ralf,

Ralf Wildenhues wrote:
It's a bug when
 libtoolize --ltdl
succeeds although it did not find the libltdl source files.

[[snip]]

Gary, could you look into a fix for CVS HEAD?  The corresponding code
looks a bit nonobvious to me.

There is code in func_copy_cb that notices missing files:

    test -f "$my_srcdir/$my_file" || \
      { func_error "\`$my_file' not found in \`$my_srcdir'"; return; }

I wonder whether the right thing to do in general is add to func_error()
a line:

    exit_status=1

Before committing such a change, I think we need to look at all the
call sites for func_error to make sure this change in semantics won't
break anything.

Cheers,
        Gary.

        * libtoolize.in: Fail if libltdl files not present but
        `--ltdl' given.
        Reported by Troy Benjegerdes <address@hidden>.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]