libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: allow some more compiler flags through


From: Ralf Wildenhues
Subject: Re: allow some more compiler flags through
Date: Sun, 20 Nov 2005 15:10:23 +0100
User-agent: Mutt/1.5.9i

Sorry for the delay.

* Gary V. Vaughan wrote on Fri, Sep 16, 2005 at 08:26:22PM CEST:
> Ralf Wildenhues wrote:
> > On a related note, `-pg' should be handled better as well, noted by Tor
> > Lillqvist[2].  One issue here is that it changes predep_objects,
> > postdep_objects, and possibly postdeps, I guess, so it should be
> > specified during configure already.  Probably a treatment similar to
> > `-pthread' in CVS HEAD could be beneficial.  OTOH, we might be
> > penalizing some legitimate use again here.  
> 
> The -pthread like treatment sounds sanest to me.  We can always look at
> it again if it turns out to cause problems later.

Committed to branch-1-5.  I haven't tested HEAD yet -- on GNU/Linux
I can't seem to be able to create a test case where leaving out '-pg'
on the link line causes any difference, when objects were created with
'-pg'.  (?)

Cheers,
Ralf

        * ltmain.in (link mode): Pass through `-pg', for GCC.
        Reported by Tor Lillqvist <address@hidden>.

Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v
retrieving revision 1.334.2.96
diff -u -r1.334.2.96 ltmain.in
--- ltmain.in   18 Nov 2005 20:29:07 -0000      1.334.2.96
+++ ltmain.in   20 Nov 2005 14:08:08 -0000
@@ -1546,8 +1546,9 @@
       # -q* pass through compiler args for the IBM compiler
       # -m* pass through architecture-specific compiler args for GCC
       # -m*, -t[45]*, -txscale* pass through architecture-specific
-      # # compiler args for GCC
-      -64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \
+      # compiler args for GCC
+      # -pg pass through profiling flag for GCC
+      -64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*|-pg| \
       -t[45]*|-txscale*)
 
        # Unknown arguments in both finalize_command and compile_command need




reply via email to

[Prev in Thread] Current Thread [Next in Thread]