[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: don't add -isysroot to compiler flags if already in $CC
From: |
Ralf Wildenhues |
Subject: |
Re: don't add -isysroot to compiler flags if already in $CC |
Date: |
Fri, 2 Dec 2005 10:17:08 +0100 |
User-agent: |
Mutt/1.5.11 |
Hi Peter,
* Peter O'Gorman wrote on Fri, Dec 02, 2005 at 02:17:59AM CET:
> Ralf Wildenhues wrote:
> >
> >OK. But I don't see where we make sure $compile_command never gets
> >duplicates.. anyway, I guess this part is fine, you'd have seen it.
>
> archive_cmds looks like "$CC ... $compiler_flags..." So if a flag is in CC
> and we grok it, we also add it to $compiler_flags when we see it on the
> command line. Any flag that we grok and put in compiler_flags will appear
> twice on the link line if it is in CC.
D'oh. Yes, right. Thanks.
> >>Is this version okay & forward port? A space and a tab check is quite
> >>satisfactory for me, I don't see the need to go overboard here.
> >
> >Any reason against using [ ] for this? I mean, other than the fact
> >that the forward-port will need another set of []?
>
> When I tried it it did not work.
> case " $c " in
> *" ${a}[ ]${b} "*) echo yippee; break;;
That should be
*\ $a[\ \ ]$b\ *)
because it works like shell globbing: double quotes inhibit the
globbing. But then you still need to work around other bugs in other
shells and end up with
spacetab='[ ]'
case " $c " in
*\ ${a}$spacetab${b}\ *) echo yippee; break;;
esac
Sorry for showing the wrong way in my earlier mail without testing. :-(
No, I don't know if that's worth the hassle.
> esac
> >No, the patch is not ok. You remove prev=darwin_framework, i.e.,
> >effectively the following argument will not be looped over, thus
> >it won't be quoted and end up in $libtool_args, thus $relink_command
> >will be wrong, thus relinking will fail, if only because there'll be
> >a `-framework' without argument in it. Right?
>
> It passed all its tests, presumably because darwin does not relink. I'll
> look into a proper fix though.
Well, I believe it may be necessary for the other flags handled in the
same places? (At least with CVS HEAD.)
Cheers,
Ralf