[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Integrating libtool head into GraphicsMagick

From: Ralf Wildenhues
Subject: Re: Integrating libtool head into GraphicsMagick
Date: Mon, 5 Dec 2005 19:01:05 +0100
User-agent: Mutt/1.5.9i

* Bob Friesenhahn wrote on Mon, Dec 05, 2005 at 06:45:26PM CET:
> On Mon, 5 Dec 2005, Bob Friesenhahn wrote:
> >I see that includes
> >
> >AM_CPPFLAGS         += -DLT_CONFIG_H='<$(LT_CONFIG_H)>' \
> >                       -DLTDL -I. -I$(srcdir) -Ilibltdl \
> >                       -I$(srcdir)/ltdl -I$(srcdir)/ltdl/libltdl
> >
> >which seems to be wrong.  I bet that the "-Ilibltdl" needs a substitution 
> >to be "-Iltdl"

The failure you're seeing is with lt__alloc.c being compiled from
$top_srcdir, right?  (Darn, I never tried non-LIBOBJ-fixed automake in
conjunction with nonrecursive on a system without argz.h.)

> Also, what is the purpose of
>   -I. -I$(srcdir)
> ???  These refer to the directory level where the Makefile lives.  Is 
> this part of the work-around for wanting newer autoconf/automake?

Nope.  This is actually for important for the recursive mode only.
We cannot know in recursive mode, whether the package has the Automake
option nostdinc set.  We should probably remove them for nonrecursive.

Please try the patch below (against current CVS).  Please also, before
applying the patch, make sure this exposes the failure:
  gmake check TESTS= TESTSUITE_FLAGS='-v -d 26-28'

(should be the three nonrecursive tests), and that after applying the
patch, these all don't fail:

  gmake check TESTS= TESTSUITE_FLAGS='-v -d 26-31'

Thanks for reporting!


        * libtoolize.m4sh (func_fixup_Makefile_inc): Mangle one more
        include path, remove two unneeded ones for nonrecursive mode.
        Reported by Bob Friesenhahn <address@hidden>.

Index: libtoolize.m4sh
RCS file: /cvsroot/libtool/libtool/libtoolize.m4sh,v
retrieving revision 1.51
diff -u -r1.51 libtoolize.m4sh
--- libtoolize.m4sh     4 Dec 2005 14:40:43 -0000       1.51
+++ libtoolize.m4sh     5 Dec 2005 17:58:20 -0000
@@ -312,6 +312,8 @@
     if $opt_dry_run; then :;
       $SED "\
+       s, -I\. -I\$(srcdir) , ,
+       s, -Ilibltdl , address@hidden@ ,
        s,: libltdl/,: @repl@/,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]