[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch-3: adjust testsuite for redistribution checks

From: Gary V. Vaughan
Subject: Re: patch-3: adjust testsuite for redistribution checks
Date: Fri, 16 Dec 2005 17:14:44 +0000
User-agent: Mozilla Thunderbird 1.0 (X11/20050305)

Ralf Wildenhues wrote:
Hi Gary,

Hey Ralf!

* Gary V. Vaughan wrote on Wed, Dec 14, 2005 at 12:41:28PM CET:

Ralf Wildenhues wrote:

        * tests/ (PREPARE_TESTS): New variable `tst_dist',
        default to empty.
        * tests/, tests/,
        tests/, tests/ Use it in
        LT_AT_BOOTSTRAP or LT_AT_MAKE, so that you can optionally test
      redistribution within the tests.

As an improvement, maybe we should test all possibilities in each
relevant test:

LT_AT_BOOTSTRAP([--copy --ltdl], [-I sub/ltdl/m4], [ignore],
        [--add-missing --copy], [], [--enable-ltdl-install --prefix=$prefix],
-       [all install])
+       [all install dist distcheck])

That's redundant, distcheck implies dist.

Assuming the libtool distribution was built in-tree, then I think
the difference is that dist doesn't use VPATH, and distcheck does.
I don't recall whether distcheck effectively tests both in that
case, so you could still be right :-)

Hmmm... although that will be agonisingly slow.  Perhaps it would be
better to make this (and the outer loop I suggested in my last email)
conditional upon an environment variable, say, LT_TEST_EXHAUSTIVE=:?


 test -z "$LT_TEST_EXHAUSTIVE" || tst_dist="dist distcheck"

As much as we might not want to subject all of our users to running
such an overly intensive test regime, making it as easy as possible for
us (and interested users) to do that would certainly improve our test

Yes, I like the idea.  For now you can
  tst_dist=distcheck make check-local
though, as a hack.  We can introduce $LT_TEST_EXHAUSTIVE later, together
with appropriate documentation (patch later in queue..).

Excellent.  Thankyou! :-D

Gary V. Vaughan      ())_.  address@hidden,}
Research Scientist   ( '/
GNU Hacker           / )=
Technical Author   `(_~)_

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]