libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: LT_AC_PROG_SED


From: Ralf Wildenhues
Subject: Re: LT_AC_PROG_SED
Date: Thu, 9 Feb 2006 17:04:31 +0100
User-agent: Mutt/1.5.11

* Ralf Wildenhues wrote on Wed, Jan 18, 2006 at 01:20:29PM CET:
> 
> Other quite serious bug:
> 
> 3) In CVS HEAD Libtool, we use
>    m4_ifndef([AC_PROG_SED],[
>    AC_DEFUN([AC_PROG_SED], [...])
>    ])
> 
> This will cause aclocal (at least up to 1.7, lower than 1.9) to
> always pull in this libtool.m4.  Even if the user does not use
> AC_PROG_LIBTOOL at all, as in:
>   AC_INIT
>   AC_PROG_SED
>   AC_OUTPUT

I have applied the patch below to HEAD to fix this.

> 4) In CVS libtool, we don't provide backward compatibility for
>    LT_AC_PROG_SED.  We probably should.

I think it would be safe to ignore this: we never advertised
LT_AC_PROG_SED.  Users would be best to not use it.  People needing it
would be best to use the Autoconf version when it is out.

Cheers,
Ralf

        * libltdl/m4/libtool.m4 (AC_PROG_SED): m4_defun this rather
        than AC_DEFUN, so that old aclocal does not pick this up.

Index: libltdl/m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.59
diff -u -r1.59 libtool.m4
--- libltdl/m4/libtool.m4       3 Feb 2006 20:03:54 -0000       1.59
+++ libltdl/m4/libtool.m4       9 Feb 2006 16:01:07 -0000
@@ -6730,7 +6730,7 @@
 #  macro and use it instead.                               #
 ############################################################
 
-AC_DEFUN([AC_PROG_SED],
+m4_defun([AC_PROG_SED],
 [AC_MSG_CHECKING([for a sed that does not truncate output])
 AC_CACHE_VAL(lt_cv_path_SED,
 [# Loop through the user's path and test for sed and gsed.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]