libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HEAD link-order.at fails when hardcode_direct=yes


From: Albert Chin
Subject: Re: HEAD link-order.at fails when hardcode_direct=yes
Date: Wed, 17 May 2006 13:37:37 -0500
User-agent: Mutt/1.5.6i

On Wed, May 17, 2006 at 04:48:24PM +0200, Ralf Wildenhues wrote:
> * Albert Chin wrote on Wed, May 17, 2006 at 02:44:49PM CEST:
> >
> > +  case $hardcode_direct$hardcode_direct_static in
> > +  yesno)
> > +    AT_CHECK([if $EGREP relinking stderr; then
> > +           $EGREP " .*\/new\/lib/libb$shrext_cmds 
> > .*\/old\/lib/libcee$shrext_cmds" stdout
> > +         else :; fi], [0], [ignore], [], [echo "wrong link order"])
> > +    ;;
> 
> You shouldn't grep for $shrext_cmds.  It's called *_cmds because it may
> contain commands.  The right way is to
>   module=no
>   eval shared_ext=\"$shrext_cmds\"

The patch below fixes this. I skipped it because I knew I wouldn't
need it for HP-UX/AIX :)

2006-05-17      Albert Chin <address@hidden>
                Ralf Wildenhues <address@hidden>

        * tests/link-order.at: Don't use $shrext_cmds directly
        because it might contain commands.

-- 
albert chin (address@hidden)

-- snip snip
Index: tests/link-order.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/link-order.at,v
retrieving revision 1.10
diff -u -p -r1.10 link-order.at
--- tests/link-order.at 17 May 2006 14:28:40 -0000      1.10
+++ tests/link-order.at 17 May 2006 16:38:15 -0000
@@ -23,6 +23,9 @@ AT_KEYWORDS([libtool])
 eval `$LIBTOOL --config | $EGREP 
'^(hardcode_direct|hardcode_direct_static|shrext_cmds)='`
 LDFLAGS="$LDFLAGS -no-undefined"
 
+module=no
+eval shared_ext=\"$shrext_cmds\"
+
 prefix_old=`pwd`/old
 prefix_new=`pwd`/new
 mkdir src $prefix_old $prefix_new $prefix_old/lib $prefix_new/lib
@@ -72,7 +75,7 @@ aix* | interix*) ;;  # These systems hav
   case $hardcode_direct$hardcode_direct_static in
   yesno)
     AT_CHECK([if $EGREP relinking stderr; then
-         $EGREP " .*\/new\/lib/libb$shrext_cmds 
.*\/old\/lib/libcee$shrext_cmds" stdout
+         $EGREP " .*\/new\/lib/libb$shared_ext .*\/old\/lib/libcee$shared_ext" 
stdout
        else :; fi], [0], [ignore], [], [echo "wrong link order"])
     ;;
   *)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]