libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: fix wrong $@ in shell wrapper


From: Ralf Wildenhues
Subject: FYI: fix wrong $@ in shell wrapper
Date: Fri, 19 May 2006 04:24:04 +0200
User-agent: Mutt/1.5.11+cvs20060403

Nesting quotes like this:
  $ECHO "$0: cannot exec $program ${1+"$@"}"

is not portable.  Furthermore, our $ECHO may get only one argument,
so word splitting (which is what $@ is for) isn't right here anyway.

I've applied the fixes below to HEAD and branch-1-5, respectively.

Cheers,
Ralf

HEAD:
        * libltdl/config/ltmain.m4sh (func_mode_link, shell wrapper):
        Do not put `"$@"' in argument to $ECHO.

Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.47
diff -u -r1.47 ltmain.m4sh
--- libltdl/config/ltmain.m4sh  18 May 2006 05:43:01 -0000      1.47
+++ libltdl/config/ltmain.m4sh  19 May 2006 02:12:49 -0000
@@ -6383,7 +6383,7 @@
          ;;
        esac
        $ECHO >> $output "\
-      \$ECHO \"\$0: cannot exec \$program \${1+\"address@hidden"}\"
+      \$ECHO \"\$0: cannot exec \$program \$*\"
       exit 1
     fi
   else

branch-1-5:
        * ltmain.in (shell wrapper): Do not put `"$@"' in argument to
        $echo.

Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v
retrieving revision 1.334.2.127
diff -u -r1.334.2.127 ltmain.in
--- ltmain.in   18 May 2006 06:52:54 -0000      1.334.2.127
+++ ltmain.in   19 May 2006 02:15:12 -0000
@@ -5448,7 +5448,7 @@
          ;;
        esac
        $echo >> $output "\
-      \$echo \"\$0: cannot exec \$program \${1+\"address@hidden"}\"
+      \$echo \"\$0: cannot exec \$program \$*\"
       exit $EXIT_FAILURE
     fi
   else




reply via email to

[Prev in Thread] Current Thread [Next in Thread]