|
From: | Bob Friesenhahn |
Subject: | Re: make libltdl work with C++ compilers |
Date: | Sun, 3 Sep 2006 11:23:13 -0500 (CDT) |
On Sun, 3 Sep 2006, Ralf Wildenhues wrote:
I've been approached about making libltdl work when compiled by a C++ compiler. While I am not a huge fan of the idea, there may be practical advantages for projects using libltdl to this. And libltdl shows strong signs of this having been supported a (rather long) time ago. The patch below is mostly mechanical, and fixes some bitrot that turned up along the way (which is definitely a good thing). With it, I can get a full testsuite pass with ./configure CC=g++
The patch seems mostly ok to me but I tend to wonder if there is more casting going on than is actually required. For example, strchr() is already defined to return a 'char *' type so the return value should not require an explicit cast to 'char *'. Casting should be viewed as "evil" unless it is intentionally incorporated as part of the design.
Bob ====================================== Bob Friesenhahn address@hidden, http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer, http://www.GraphicsMagick.org/
[Prev in Thread] | Current Thread | [Next in Thread] |