libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: make new tests a bit more autotest-friendly


From: Ralf Wildenhues
Subject: FYI: make new tests a bit more autotest-friendly
Date: Mon, 11 Sep 2006 23:35:24 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

Applied to HEAD: Autotest disables tracing for the braced type of
parameter expansion but not for the unbraced (and has good reason
to do so).  Since traces are helpful, let's not use them if they
are not necessary.  This only matters for AT_CHECK, but to be
consistent, I changed the other usages as well.

Cheers,
Ralf

        * tests/inherited_flags.at: Drop `${parameter}' for `$parameter'
        where appropriate, for improved `testsuite -x' output.

Index: tests/inherited_flags.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/inherited_flags.at,v
retrieving revision 1.8
diff -u -r1.8 inherited_flags.at
--- tests/inherited_flags.at    5 Feb 2006 09:56:44 -0000       1.8
+++ tests/inherited_flags.at    11 Sep 2006 21:34:23 -0000
@@ -1,5 +1,5 @@
 # Hand crafted tests for GNU Libtool.                         -*- Autotest -*-
-# Copyright 2004 Free Software Foundation, Inc.
+# Copyright 2004, 2006 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -40,12 +40,12 @@
 int main() { return 0;}
 ])
 
-${LIBTOOL} --mode=compile --tag=CC $CC $CFLAGS -c -o foo.lo foo.c
-${LIBTOOL} --mode=compile --tag=CC $CC $CFLAGS -c -o bar.lo bar.c
-${LIBTOOL} --mode=compile --tag=CC $CC $CFLAGS -c -o baz.lo baz.c
-${LIBTOOL} --mode=compile --tag=CC $CC $CFLAGS -c -o main.lo main.c
-${LIBTOOL} --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libfoo.la foo.lo 
-rpath /usr/local/lib -no-undefined
-${LIBTOOL} --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libbar.la bar.lo 
-rpath /usr/local/lib -no-undefined
+$LIBTOOL --mode=compile --tag=CC $CC $CFLAGS -c -o foo.lo foo.c
+$LIBTOOL --mode=compile --tag=CC $CC $CFLAGS -c -o bar.lo bar.c
+$LIBTOOL --mode=compile --tag=CC $CC $CFLAGS -c -o baz.lo baz.c
+$LIBTOOL --mode=compile --tag=CC $CC $CFLAGS -c -o main.lo main.c
+$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libfoo.la foo.lo -rpath 
/usr/local/lib -no-undefined
+$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libbar.la bar.lo -rpath 
/usr/local/lib -no-undefined
 
 
 mv libfoo.la libfoo.la.bak
@@ -56,16 +56,16 @@
 sed -e 
's/^inherited_linker_flags.*/inherited_linker_flags=-llt_unlikely_existing_lib/g'
 < libbar.la.bak > libbar.la
 rm libbar.la.bak
 
-AT_CHECK([${LIBTOOL} --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libbaz.la 
baz.lo -no-undefined -rpath /usr/local/lib ./libfoo.la ./libbar.la],
+AT_CHECK([$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libbaz.la 
baz.lo -no-undefined -rpath /usr/local/lib ./libfoo.la ./libbar.la],
         [ignore],[stdout],[ignore])
 # We used to grep for
 # 'llt_[[ui]]nlikely_existing_lib.*llt_[[ui]]nlikely_existing_lib'
 # here.  This fails on win32/MSVC because the generated command lines have a
 # different syntax.  So drop the first `l'.
-AT_CHECK([${LIBTOOL} --features | grep 'disable shared libraries' && (exit 
77)], [1], [ignore])
+AT_CHECK([$LIBTOOL --features | grep 'disable shared libraries' && (exit 77)], 
[1], [ignore])
 AT_CHECK([grep 'lt_[[ui]]nlikely_existing_lib.*lt_[[ui]]nlikely_existing_lib' 
stdout],
         [0],[ignore],[ignore])
-AT_CHECK([${LIBTOOL} --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o main main.lo 
-no-undefined -rpath /usr/local/lib  ./libfoo.la ./libbar.la],
+AT_CHECK([$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o main main.lo 
-no-undefined -rpath /usr/local/lib  ./libfoo.la ./libbar.la],
        [ignore],[stdout],[ignore])
 AT_CHECK([grep 'lt_[[ui]]nlikely_existing_lib.*lt_[[ui]]nlikely_existing_lib' 
stdout],
         [0],[ignore],[ignore])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]