Re: 317-gary-simplify-verbatim-shell-quoting.diff

[Gary V. Vaughan]

On 5 Mar 2007, at 09:51, Ralf Wildenhues wrote:
> Hello Gary,

Hallo Ralf!

> * Gary V. Vaughan wrote on Mon, Mar 05, 2007 at 11:46:59AM CET:
> > The vast majority of this patch is the removal of extraneous m4
> > quotes enabled by adding and using the M4SH_VERBATIM macro to
> > general.m4sh.
> >
> > Okay to commit?
>
> Please fix the bugs below, manually remove (so that inadvertently not
> using Makefile.maint won't skew your observations) and regenerate all
> files involved (libtool, libtoolize, tests/defs, $srcdir/commit, and
> $srcdir/libltdl/config/mailnotify) and check that there are only
> whitespace differences against the version without the patch, add some
> blurb about M4SH_VERBATIM to HACKING, and apply.  Thank you.

Thanks for the quick review!

> $ diff libtoolize-before libtoolize-after
> 1450c1458
> < 	func_echo "Consider adding \`AC_CONFIG_MACRO_DIR(m4)' to  
> $configure_ac and rerunning"
> ---
> > 	func_echo "Consider adding \`AC_CONFIG_MACRO_DIR([m4])' to  
> > $configure_ac and rerunning"
> 1453c1461
> < 	func_echo "Consider adding \`AC_CONFIG_MACRO_DIR($m4dir)'to  
> $configure.ac,"
> ---
> > 	func_echo "Consider adding \`AC_CONFIG_MACRO_DIR([$m4dir])'to  
> > $configure.ac,"
> 1733a1742

Actually, the quote change here fixes a bug IMHO.  I'd like to leave  
these in...
though I should add a note to ChangeLog before committing.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_ Join my AGLOCO Network: http://www.agloco.com/r/BBBS7912

PGP.sig
Description: This is a digitally signed message part