Re: 329-gary-allow-RTLD_GLOBAL

[Gary V. Vaughan]

Hi Bob!

On 10 Apr 2007, at 15:35, Bob Friesenhahn wrote:
> On Tue, 10 Apr 2007, Gary V. Vaughan wrote:
> >  int errors = 0;
> >  lt_dlhandle handle;
> >  lt_dladvise advise = lt_dladvise_init ();
> >
> >  if (advise == 0)
> >    return 1;
>
> Not ideal.  By comparing with zero there is an implicit assumption  
> regarding the lt_dladvise type.  It is usually better to avoid any  
> user knowledge of the type:
>
>   lt_dladvise advise;
>   if (!lt_dladvise_init(&advise))
>      return 1;
>
> In this way, lt_dladvise can be a pointer, an integer, or a structure.

Okay, I'm happy to do it that way :-)

We already decided that it will be a pointer for future ABI  
compatibility
though, right?

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_ Join my AGLOCO Network: http://www.agloco.com/r/BBBS7912

PGP.sig
Description: This is a digitally signed message part