Re: NLS sanitization

[Ralf Wildenhues]

[ http://lists.gnu.org/archive/html/autoconf-patches/2007-10/msg00101.html ]

Hello Paul,

* Paul Eggert wrote on Wed, Oct 10, 2007 at 09:20:19AM CEST:
[...]
> There is no longer any reason to worry about ancient hosts where setting
> LC_ALL=C produced diagnostics.  These hosts died many years ago.
> 
> The LANGUAGE=C business is needed to avoid problems with glibc versions
> that predate this change to glibc:
> 
> 2001-01-02  Ulrich Drepper  <address@hidden>
> 
>       * intl/dcigettext.c (guess_category_value): Rewrite so that LANGUAGE
>       value is ignored if the selected locale is the C locale.
> 
> I suppose there are still a few hosts where that's an issue, so we
> might as well still cater to them.

Thanks for this explanation!  I'm applying the changes below to Libtool
HEAD and branch-1-5, respectively.

Cheers,
Ralf

2007-10-12  Ralf Wildenhues  <address@hidden>

        * libltdl/config/ltmain.m4sh: Also sanitize `LANGUAGE'.
        (func_mode_execute): Also restore `LANGUAGE', for old glibc.
        Report by Paul Eggert against Autoconf.

Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.90
diff -u -r1.90 ltmain.m4sh
--- libltdl/config/ltmain.m4sh  9 Oct 2007 19:32:45 -0000       1.90
+++ libltdl/config/ltmain.m4sh  12 Oct 2007 16:29:57 -0000
@@ -96,7 +96,7 @@
 # Only set LANG and LC_ALL to C if already set.
 # These must not be set unconditionally because not all systems understand
 # e.g. LANG=C (notably SCO).
-for lt_var in LANG LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
+for lt_var in LANG LANGUAGE LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
 do
   eval "if test \"\${$lt_var+set}\" = set; then
           save_$lt_var=\$$lt_var
@@ -1714,7 +1714,7 @@
       fi
 
       # Restore saved environment variables
-      for lt_var in LANG LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
+      for lt_var in LANG LANGUAGE LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
       do
        eval "if test \"\${save_$lt_var+set}\" = set; then
                 $lt_var=\$save_$lt_var; export $lt_var


2007-10-12  Ralf Wildenhues  <address@hidden>

        * ltmain.in: Also sanitize `LANGUAGE'.
        (execute mode): Also restore `LANGUAGE', for old glibc.
        Report by Paul Eggert against Autoconf.

Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v
retrieving revision 1.334.2.143
diff -u -r1.334.2.143 ltmain.in
--- ltmain.in   9 Oct 2007 19:34:04 -0000       1.334.2.143
+++ ltmain.in   12 Oct 2007 16:30:34 -0000
@@ -113,7 +113,7 @@
 # These must not be set unconditionally because not all systems understand
 # e.g. LANG=C (notably SCO).
 # We save the old values to restore during execute mode.
-for lt_var in LANG LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
+for lt_var in LANG LANGUAGE LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
 do
   eval "if test \"\${$lt_var+set}\" = set; then
          save_$lt_var=\$$lt_var
@@ -6479,7 +6479,7 @@
       fi
 
       # Restore saved environment variables
-      for lt_var in LANG LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
+      for lt_var in LANG LANGUAGE LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
       do
        eval "if test \"\${save_$lt_var+set}\" = set; then
                $lt_var=\$save_$lt_var; export $lt_var