Re: libtoolize /ltmain.sh bug

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Mon, Feb 11, 2008 at 11:01:53PM CET:
> 
> In an empty directory this happens:
> 
> $ libtoolize --copy --ltdl
> touch: cannot touch `/ltmain.sh': Permission denied
> libtoolize: can not copy `/home/ralf/local/share/libtool/config/ltmain.sh' to 
> `/'
> libtoolize: copying file `libltdl/config/compile'
[...]
> First, the toplevel directory isn't even a package, so it should not get
> an ltmain.sh file at all (it does, however, unlike what the bogus error
> suggests).  Second, there is a '.' missing before /ltmain.sh.

Proposed patch.  OK to apply?

Cheers,
Ralf

2008-02-13  Ralf Wildenhues  <address@hidden>

        * libtoolize.m4sh (func_install_pkgconfig_files): Only call
        func_install_pkgconfig_parent if $seen_autoconf.
        * tests/standalone.at (compiling softlinked libltdl)
        (compiling copied libltdl, installable libltdl)
        (linking libltdl without autotools): Use checked libtoolize
        calls to catch warnings.

Index: libtoolize.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libtoolize.m4sh,v
retrieving revision 1.75
diff -u -r1.75 libtoolize.m4sh
--- libtoolize.m4sh     31 Jan 2008 16:17:06 -0000      1.75
+++ libtoolize.m4sh     13 Feb 2008 22:10:56 -0000
@@ -1202,7 +1202,9 @@
     elif $opt_ltdl && test "x$ltdl_mode" = "xsubproject"
        # && test "x$auxdir" != "x$subproject_auxdir" is implied
     then
-      func_install_pkgconfig_parent
+      if $seen_autoconf; then
+       func_install_pkgconfig_parent
+      fi
       func_install_pkgconfig_subproject
 
   # 3. Not subproject, but AC_CONFIG_AUX_DIR was used in parent:
Index: tests/standalone.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/standalone.at,v
retrieving revision 1.7
diff -u -r1.7 standalone.at
--- tests/standalone.at 25 Mar 2007 12:12:43 -0000      1.7
+++ tests/standalone.at 13 Feb 2008 22:10:56 -0000
@@ -1,6 +1,6 @@
 # standalone.at -- test standalone libltdl builds             -*- Autotest -*-
 #
-#   Copyright (C) 2005 Free Software Foundation, Inc.
+#   Copyright (C) 2005, 2008 Free Software Foundation, Inc.
 #   Written by Gary V. Vaughan, 2006
 #
 #   This file is part of GNU Libtool.
@@ -30,7 +30,7 @@
 
 AT_SETUP([compiling softlinked libltdl])
 
-LT_AT_LIBTOOLIZE([--ltdl=.])
+LT_AT_CHECK_LIBTOOLIZE([--ltdl=.], [], [ignore])
 LT_AT_CONFIGURE
 LT_AT_MAKE([all $tst_dist])
 
@@ -45,7 +45,7 @@
 
 AT_SETUP([compiling copied libltdl])
 
-LT_AT_LIBTOOLIZE([--copy --ltdl=.])
+LT_AT_CHECK_LIBTOOLIZE([--copy --ltdl=.], [], [ignore])
 LT_AT_CONFIGURE
 LT_AT_MAKE([all $tst_dist])
 
@@ -62,7 +62,7 @@
 
 prefix=`pwd`/_inst
 
-LT_AT_LIBTOOLIZE([--copy --ltdl=.])
+LT_AT_CHECK_LIBTOOLIZE([--copy --ltdl=.], [], [ignore])
 LT_AT_CONFIGURE([--enable-ltdl-install --prefix=$prefix])
 LT_AT_MAKE([all install $tst_dist])
 
@@ -79,7 +79,7 @@
 AT_SETUP([linking libltdl without autotools])
 
 _LTDL_PROJECT_FILES([libltdl])
-LT_AT_LIBTOOLIZE([--copy --ltdl])
+LT_AT_CHECK_LIBTOOLIZE([--copy --ltdl], [], [ignore])
 LT_AT_MAKE([], [CC="$CC" LIBTOOLFLAGS="$LIBTOOLFLAGS" CPPFLAGS="$CPPFLAGS" \
         CFLAGS="$CFLAGS" LDFLAGS="$LDFLAGS" \
        CONFIGURE_OPTIONS="$configure_options"])